This is an archive of the discontinued LLVM Phabricator instance.

[SveEmitter] Add builtins for gather prefetches
ClosedPublic

Authored by sdesmalen on Apr 22 2020, 2:43 PM.

Diff Detail

Event Timeline

sdesmalen created this revision.Apr 22 2020, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 2:43 PM
Herald added a subscriber: tschuett. · View Herald Transcript
sdesmalen updated this revision to Diff 259589.Apr 23 2020, 8:57 AM
  • Updated the tests to use SVE_ACLE_FUNC for the overloaded builtins.
efriedma accepted this revision.Apr 28 2020, 6:42 PM

LGTM with one minor comment

clang/lib/CodeGen/CGBuiltin.cpp
7739

} else {, so you aren't multiplying by zero?

This revision is now accepted and ready to land.Apr 28 2020, 6:42 PM
sdesmalen marked an inline comment as done.Apr 29 2020, 3:57 AM

Thanks for reviewing!

clang/lib/CodeGen/CGBuiltin.cpp
7739

Good catch, I've fixed that before committing.

This revision was automatically updated to reflect the committed changes.