This is an archive of the discontinued LLVM Phabricator instance.

[llvm][NFC][CallSite] Remove CallSite from TypeMetadataUtils & related
ClosedPublic

Authored by mtrofin on Apr 22 2020, 1:19 PM.

Diff Detail

Event Timeline

mtrofin created this revision.Apr 22 2020, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 1:19 PM
craig.topper added inline comments.Apr 22 2020, 9:56 PM
llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
356

Why the "= nullptr"?

470

Can we rename this variable while you're here? I'm not sure what CI was meant to stand for. And its shadowed by another CI inside the loop.

1281

Would Args.append(CB.arg_begin(), CB.arg_end()) work here?

mtrofin updated this revision to Diff 259479.Apr 22 2020, 10:33 PM
mtrofin marked 4 inline comments as done.

feedback

llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
356

Drive-by change. Lower chance of later maintainability issues, and it's easy and harmless to set it here (same for NumUnsafeUses)

This revision is now accepted and ready to land.Apr 22 2020, 10:54 PM
This revision was automatically updated to reflect the committed changes.