This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add a tests for out of tree dialect example.
ClosedPublic

Authored by stephenneuendorffer on Apr 22 2020, 10:55 AM.

Details

Summary

This attempts to ensure that out of tree usage remains stable.

Diff Detail

Event Timeline

stephenneuendorffer retitled this revision from [MLIR] Experimental: Add a tests for out of tree dialect example. to [MLIR] Add a tests for out of tree dialect example..
stephenneuendorffer edited the summary of this revision. (Show Details)

If there are no objections, I plan to land this.

jroelofs added inline comments.
mlir/test/Examples/standalone/test.toy
2

Should this be tee %t so there's no chance of collisions with other tests writing to the same generically-named file?

mlir/test/lit.site.cfg.py.in
26

I think you want "@CMAKE_COMMAND@"

stephenneuendorffer edited the summary of this revision. (Show Details)
stephenneuendorffer marked 2 inline comments as done.Apr 29 2020, 12:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 5 2020, 9:41 AM
This revision was automatically updated to reflect the committed changes.