This is an archive of the discontinued LLVM Phabricator instance.

Add `//` before the banner displayed in `--print-ir-before/after-all`
ClosedPublic

Authored by mehdi_amini on Apr 21 2020, 5:33 PM.

Details

Summary

This is making the output file (when the stream is a file) a valid MLIR
file.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2020, 5:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle accepted this revision.Apr 21 2020, 5:40 PM

nit: Can you add a space between the / and the *?

This revision is now accepted and ready to land.Apr 21 2020, 5:40 PM
This revision was automatically updated to reflect the committed changes.

Does it make it valid? Wouldn't you have the same function being redefined?

Does it make it valid? Wouldn't you have the same function being redefined?

In TensorFlow: we emit a new file on every invocation right now, and we print a full module. When I get dump for reproduction the only change I make is opening the file and deleting the first line :)