Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D78603

remove unused function LLDBSwigPython_GetIndexOfChildWithName
AbandonedPublic
Actions

Authored by lawrence_danna on Apr 21 2020, 5:30 PM.

Details

Reviewers
labath
jasonmolenda
JDevlieghere
Summary

Remove LLDBSwigPython_GetIndexOfChildWithName and associated functions.
They are not used.

Diff Detail

Unit TestsFailed
View All

TimeTest
11,630 mslldb-api.commands/expression/import-std-module/basic::Unknown Unit Message ("")
3,410 mslldb-api.commands/expression/import-std-module/conflicts::Unknown Unit Message ("")
5,870 mslldb-api.commands/expression/import-std-module/deque-basic::Unknown Unit Message ("")
5,860 mslldb-api.commands/expression/import-std-module/deque-dbg-info-content::Unknown Unit Message ("")
5,440 mslldb-api.commands/expression/import-std-module/forward_list::Unknown Unit Message ("")
View Full Test Results (44 Failed)

Event Timeline

lawrence_danna created this revision.Apr 21 2020, 5:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2020, 5:30 PM
Herald added subscribers: lldb-commits, arphaman. · View Herald Transcript
Harbormaster failed remote builds in B54177: Diff 259136!Apr 21 2020, 6:25 PM
labath accepted this revision.Apr 22 2020, 1:13 AM

cool

This revision is now accepted and ready to land.Apr 22 2020, 1:13 AM
JDevlieghere accepted this revision.Apr 24 2020, 9:28 AM
lawrence_danna abandoned this revision.May 18 2020, 11:46 AM

despite there being no references to this function, it is not actually unused.

This change causes TestFormattersSBAPI.py to fail.

Revision Contents
Changeset List

PathSize
lldb/
bindings/
python/
29 lines
source/
Plugins/
ScriptInterpreter/
Python/
25 lines
2 lines
unittests/
ScriptInterpreter/
Python/
5 lines

Diff 259136

View Options

lldb/bindings/python/python-wrapper.swig

Loading...
View Options

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

Loading...
View Options

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h

Loading...
View Options

lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp

Loading...