This is an archive of the discontinued LLVM Phabricator instance.

# Folder for division by one.
ClosedPublic

Authored by phoenix-meadowlark on Apr 20 2020, 2:26 PM.

Details

Summary
  • Adds a folder for integer division by one with the divi_signed and divi_unsigned ops.
  • Creates tests for scalar and tensor versions of these ops.
  • Modifies the test in parallel-loop-collapsing.mlir so that it doesn't assume division by one will be in the output.

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2020, 2:26 PM
mehdi_amini accepted this revision.Apr 20 2020, 3:43 PM
This revision is now accepted and ready to land.Apr 20 2020, 3:43 PM
rriddle accepted this revision.Apr 20 2020, 3:47 PM
rriddle added inline comments.
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
1725

This comment looks weirdly placed, can you move it to a more appropriate location?

2261

Same here.

Moved comments to a better location.

Do you need someone to commit this for you? (if so please mention it in the comment in general)

phoenix-meadowlark marked 2 inline comments as done.Apr 27 2020, 12:57 PM

Do you need someone to commit this for you? (if so please mention it in the comment in general)

I do! Thank you for letting me know. I will in the future.

This revision was automatically updated to reflect the committed changes.