This is an archive of the discontinued LLVM Phabricator instance.

Differential D78205

[builtins] Fix unprototypes function declaration
ClosedPublic

Authored by aykevl on Apr 15 2020, 6:43 AM.

Details

Reviewers
MaskRay
kongyi
efriedma
joerg
peter.smith
Commits
rGd9e5691843a9: [builtins] Fix unprototypes function declaration
Summary

The following declarations were missing a prototype:

FE_ROUND_MODE __fe_getround();
int __fe_raise_inexact();

Discovered while fixing a bug in Clang related to unprototyped function calls (D78125).

Diff Detail

Event Timeline

aykevl created this revision.Apr 15 2020, 6:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 6:43 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster failed remote builds in B53353: Diff 257703!Apr 15 2020, 7:05 AM
joerg accepted this revision.Apr 15 2020, 7:30 AM

LGTM

This revision is now accepted and ready to land.Apr 15 2020, 7:30 AM
MaskRay accepted this revision.Apr 15 2020, 7:43 AM

LGTM.

Closed by commit rGd9e5691843a9: [builtins] Fix unprototypes function declaration (authored by aykevl). · Explain WhyApr 15 2020, 2:56 PM
This revision was automatically updated to reflect the committed changes.
aykevl mentioned this in D78641: [builtins] Add void prototype to unprototyped functions.Apr 22 2020, 12:50 PM

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
4 lines

Diff 257703

compiler-rt/lib/builtins/fp_mode.h

Show All 17 Lines
typedef enum { typedef enum {
FE_TONEAREST, FE_TONEAREST,
FE_DOWNWARD, FE_DOWNWARD,
FE_UPWARD, FE_UPWARD,
FE_TOWARDZERO FE_TOWARDZERO
} FE_ROUND_MODE; } FE_ROUND_MODE;
FE_ROUND_MODE __fe_getround(); FE_ROUND_MODE __fe_getround(void);
int __fe_raise_inexact(); int __fe_raise_inexact(void);
#endif // FP_MODE_H #endif // FP_MODE_H