Page MenuHomePhabricator

[AbstractCallSite] Check that callback callee index is within call arguments
ClosedPublic

Authored by sdmitriev on Apr 14 2020, 8:20 AM.

Details

Summary

AbstractCallSite::getCallbackUses() does not check that callback callee index from
the callback metadata does not exceed the total number of call arguments. This patch
add such validation check.

Diff Detail

Event Timeline

sdmitriev created this revision.Apr 14 2020, 8:20 AM
Herald added a project: Restricted Project. · View Herald Transcript
jdoerfert accepted this revision.Apr 14 2020, 8:39 AM

It's unclear in how much trouble we are if the callback metadata is not matching the semantics but this seems reasonable. LGTM.

This revision is now accepted and ready to land.Apr 14 2020, 8:39 AM
This revision was automatically updated to reflect the committed changes.