Page MenuHomePhabricator

[mlir] NFC: Fix trivial typo under Dialects
ClosedPublic

Authored by kiszk on Apr 14 2020, 1:25 AM.

Diff Detail

Event Timeline

kiszk created this revision.Apr 14 2020, 1:25 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ftynse requested changes to this revision.Apr 14 2020, 1:45 AM
ftynse added a subscriber: ftynse.

Thanks!

While making spelling and wording changes, please make sure the original meaning of the text is maintainted.

mlir/docs/Dialects/GPU.md
26 ↗(On Diff #257226)

I don't think the fix here is correct. You could rephrase it as "are considered to _be_ live" (or keep as is, which is equivalent), but not as "to live".

mlir/docs/Dialects/LLVM.md
406

We did intend to use "unique" as a verb, and do so repeatedly in multiple places. We use "to unique" to refer to the process of making something unique. You'll notice that "will be unique by the module" does not sound correct grammatically, similarly to "will be fix by the module" for example.

mlir/docs/Dialects/SPIR-V.md
175

This sounds correct, but no longer conveys the same meaning. The original meaning is that attributes are _made_ unique by the MLIR context.

242

Same as above

1012

There is only one type index type, so changing it to plural here is not correct.

mlir/docs/Dialects/Vector.md
47

I'd rather make it "the NVVM" dialect :)

This revision now requires changes to proceed.Apr 14 2020, 1:45 AM
kiszk marked an inline comment as done.Apr 14 2020, 1:51 AM
kiszk added inline comments.
mlir/docs/Dialects/GPU.md
26 ↗(On Diff #257226)

Thank you for your comment.

mlir/docs/Dialects/LLVM.md
406

Thank you for your clarification. I understand the intention I thought that "unique" is an adjective.
I will revert them.

mlir/docs/Dialects/Vector.md
47

I tried to keep the original usage. But, I totally agree with you.

kiszk marked an inline comment as done.Apr 14 2020, 2:06 AM
kiszk added inline comments.
mlir/docs/Dialects/SPIR-V.md
1012

I agree. In that case, do we update standard vector types and Standard memref types based on the comment?

kiszk updated this revision to Diff 257244.Apr 14 2020, 2:36 AM

address review comments

ftynse accepted this revision.Apr 14 2020, 2:39 AM

Thanks!

This revision is now accepted and ready to land.Apr 14 2020, 2:39 AM

This does not seem to apply, please rebase.

kiszk updated this revision to Diff 259032.Apr 21 2020, 9:43 AM

The previous diff reverted some of changes in the first revision.

This revision was automatically updated to reflect the committed changes.