Define SDBM key methods in its own cpp file.

[stellaraccident]

Summary

• Follows the convention of the tablegen-generated dialects.
• Ensures that vague linkage rules place the definitions in the dialect's object files.
• Allows code that uses RTTI to include MLIR headers (compiled without RTTI) without type_info link errors.

[stellaraccident]

Installed clang-format.

[stellaraccident]

Update comment.

[rriddle]

mlir/include/mlir/Dialect/SDBM/SDBMDialect.h

22

Please use /// for top-level comments.

mlir/lib/Dialect/SDBM/SDBMDialect.cpp

10

nit: This comment block can probably just be removed.

[stellaraccident]

Address comments.

[stellaraccident]

Install clang-format.

mlir/include/mlir/Dialect/SDBM/SDBMDialect.h

 
 namespace mlir {
 class MLIRContext;
 
 class SDBMDialect : public Dialect {
 public:
   SDBMDialect(MLIRContext *context) : Dialect(getDialectNamespace(), context) {}
 
+  /// Since there are no other virtual methods in this derived class, override
+  /// the destructor so that key methods get defined in the corresponding
+  /// module.
+  ~SDBMDialect() override;
+
   static StringRef getDialectNamespace() { return "sdbm"; }
 
   /// Get the uniquer for SDBM expressions. This should not be used directly.
   StorageUniquer &getUniquer() { return uniquer; }
 
 private:
   StorageUniquer uniquer;
 };
 } // namespace mlir
 
 #endif // MLIR_DIALECT_SDBM_SDBMDIALECT_H

mlir/lib/Dialect/SDBM/CMakeLists.txt

 add_mlir_dialect_library(MLIRSDBM
   SDBM.cpp
+  SDBMDialect.cpp
   SDBMExpr.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SDBM
 )
 target_link_libraries(MLIRSDBM
   PUBLIC
   MLIRIR
   )

mlir/lib/Dialect/SDBM/SDBMDialect.cpp

+//===- SDBMDialect.cpp - MLIR SDBM Dialect --------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "mlir/Dialect/SDBM/SDBMDialect.h"
+
+using namespace mlir;
+
+SDBMDialect::~SDBMDialect() = default;