This is an archive of the discontinued LLVM Phabricator instance.

Differential D78036

Add missing dependencies on the flang test target
ClosedPublic

Authored by mehdi_amini on Apr 13 2020, 10:05 AM.

Details

Reviewers
DavidTruby
sscalpone
Commits
rGed6c452edc81: Add missing dependencies on the flang test target
Summary

Without this, the LLVM utilities (FileCheck) aren't built when running
ninja check-flang and it fails with:

llvm-project/llvm/utils/lit/lit/llvm/subst.py:134: fatal: Did not find FileCheck in...

Also the modules aren't built without depending on module_files, which
makes multiple tests failing.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 13 2020, 10:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2020, 10:05 AM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
Harbormaster failed remote builds in B52948: Diff 257016!Apr 13 2020, 11:18 AM
DavidTruby accepted this revision.Apr 13 2020, 11:20 AM

LGTM, I never tried running check-flang without building first so this is my fault!

This revision is now accepted and ready to land.Apr 13 2020, 11:20 AM
mehdi_amini updated this revision to Diff 257042.Apr 13 2020, 11:21 AM

rebase

Harbormaster failed remote builds in B52962: Diff 257042!Apr 13 2020, 11:53 AM
Closed by commit rGed6c452edc81: Add missing dependencies on the flang test target (authored by mehdi_amini). · Explain WhyApr 13 2020, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
flang/
test/
2 lines

Diff 257049

flang/test/CMakeLists.txt

Show All 12 Lines
) )
add_subdirectory(Semantics) add_subdirectory(Semantics)
set(FLANG_TEST_PARAMS set(FLANG_TEST_PARAMS
flang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py) flang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py)
set(FLANG_TEST_DEPENDS set(FLANG_TEST_DEPENDS
f18 f18 FileCheck count not module_files
) )
if (LINK_WITH_FIR) if (LINK_WITH_FIR)
list(APPEND FLANG_TEST_DEPENDS tco) list(APPEND FLANG_TEST_DEPENDS tco)
endif() endif()
add_custom_target(flang-test-depends DEPENDS ${FLANG_TEST_DEPENDS}) add_custom_target(flang-test-depends DEPENDS ${FLANG_TEST_DEPENDS})
Show All 11 Lines