This is an archive of the discontinued LLVM Phabricator instance.

Differential D78029

Support Apple platforms in llvm::get_thread_name
Needs ReviewPublic

Authored by broadwaylamb on Apr 13 2020, 8:53 AM.

Details

Reviewers
zturner

Diff Detail

Event Timeline

broadwaylamb created this revision.Apr 13 2020, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2020, 8:53 AM
Herald added subscribers: llvm-commits, hiraditya, krytarowski. · View Herald Transcript
Harbormaster failed remote builds in B52938: Diff 256996!Apr 13 2020, 9:39 AM

Revision Contents

PathSize
llvm/
lib/
Support/
Unix/
2 lines

Diff 256996

llvm/lib/Support/Unix/Threading.inc

Show First 20 Lines • Show All 213 Lines • ▼ Show 20 Lines#elif defined(__NetBSD__)
Name.append(buf, buf + strlen(buf)); Name.append(buf, buf + strlen(buf));
#elif defined(__OpenBSD__) #elif defined(__OpenBSD__)
constexpr uint32_t len = get_max_thread_name_length_impl(); constexpr uint32_t len = get_max_thread_name_length_impl();
char buf[len]; char buf[len];
::pthread_get_name_np(::pthread_self(), buf, len); ::pthread_get_name_np(::pthread_self(), buf, len);
Name.append(buf, buf + strlen(buf)); Name.append(buf, buf + strlen(buf));
#elif defined(__linux__) #elif defined(__linux__) || defined(__APPLE__)
#if HAVE_PTHREAD_GETNAME_NP #if HAVE_PTHREAD_GETNAME_NP
constexpr uint32_t len = get_max_thread_name_length_impl(); constexpr uint32_t len = get_max_thread_name_length_impl();
char Buffer[len] = {'\0'}; // FIXME: working around MSan false positive. char Buffer[len] = {'\0'}; // FIXME: working around MSan false positive.
if (0 == ::pthread_getname_np(::pthread_self(), Buffer, len)) if (0 == ::pthread_getname_np(::pthread_self(), Buffer, len))
Name.append(Buffer, Buffer + strlen(Buffer)); Name.append(Buffer, Buffer + strlen(Buffer));
#endif #endif
#endif #endif
} }
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines