This is an archive of the discontinued LLVM Phabricator instance.

[X86] Move X86ShuffleDecode.cpp/h into MCTargetDesc and remove X86Utils library. NFC
ClosedPublic

Authored by craig.topper on Apr 12 2020, 1:28 PM.

Details

Summary

The shuffle decoding is used by X86ISelLowering and
MCTargetDesc/X86InstComments. The latter used to be in a
separate InstPrinter library. The Utils library existed to allow
InstPrinter and CodeGen to share the shuffle decoding. Since
X86InstComments now lives in the MCTargetDesc, which CodeGen
already depends on, we can sink the shuffle decoding there as well.

Diff Detail

Event Timeline

craig.topper created this revision.Apr 12 2020, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2020, 1:28 PM

Include the moved files properly.

Harbormaster completed remote builds in B52872: Diff 256878.
RKSimon accepted this revision.Apr 13 2020, 3:55 AM

LGTM

This revision is now accepted and ready to land.Apr 13 2020, 3:55 AM
This revision was automatically updated to reflect the committed changes.
llvm/lib/Target/X86/MCTargetDesc/X86ShuffleDecode.cpp