Page MenuHomePhabricator

[mlir][spirv] Add a `spirv::InterfaceVarABIAttr`.
ClosedPublic

Authored by denis13 on Apr 11 2020, 6:00 AM.

Details

Summary

Add a proper dialect-specific attribute for interface variable ABI.

Diff Detail

Event Timeline

denis13 created this revision.Apr 11 2020, 6:00 AM
Herald added a project: Restricted Project. · View Herald Transcript
antiagainst accepted this revision.Apr 13 2020, 10:26 AM

Awesome! Thanks Denis! Just two nits. Feel free to submit after fixing them. :)

mlir/docs/Dialects/SPIR-V.md
892

integer-literal. same for the following

mlir/include/mlir/Dialect/SPIRV/SPIRVAttributes.h
44

s/global/interface/

This revision is now accepted and ready to land.Apr 13 2020, 10:26 AM
mravishankar accepted this revision.Apr 13 2020, 10:32 AM

@antiagainst thanks for review!I'll fix it.

This revision was automatically updated to reflect the committed changes.