Details
- Reviewers
sammccall - Commits
- rG8c68de2d6300: [clangd] Extend YAML Serialization
Diff Detail
Event Timeline
This was previously part of D77385. Rather than a separate file (which seems a bit tricky), the test YAML has simply been included in the unit test itself.
Thanks for doing this!
clang-tools-extra/clangd/unittests/YAMLTests.cpp | ||
---|---|---|
1 | Ack, sorry for not mentioning this in the previous review. |
Thank you!
Do you have commit access, or would you like me to land this and D78038 for you?
I do not have commit access, so it would be helpful that you land this (and the other) ;-)
Done, thanks for the contributions!
Feel free to apply for commit access at any point if you plan to work more on clangd or other LLVM stuff.
Ack, sorry for not mentioning this in the previous review.
The YAML stuff is tested mixed together with the binary format stuff in SerializationTests.cpp.
Is it possible to extend the YAML literal in that file with a synthetic Source and Cmd entry, and test it in a similar way?