Page MenuHomePhabricator

mnauw (Mark Nauwelaerts)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 1:39 AM (93 w, 3 d)

Recent Activity

Dec 1 2020

mnauw committed rG1e4d6d1c1ff3: [clang-format] Add new option PenaltyIndentedWhitespace (authored by mnauw).
[clang-format] Add new option PenaltyIndentedWhitespace
Dec 1 2020, 3:01 PM
mnauw closed D90534: [clang-format] Add new option PenaltyIndentedWhitespace.
Dec 1 2020, 3:01 PM · Restricted Project, Restricted Project

Nov 15 2020

mnauw abandoned D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter.

Looks like PenaltyBreakBeforeFirstCallParameter not being considered so well has been addressed somewhat differently in D90246, and so that does the job as well.

Nov 15 2020, 4:32 AM · Restricted Project, Restricted Project

Nov 10 2020

mnauw added a comment to D90534: [clang-format] Add new option PenaltyIndentedWhitespace.

Thanks. However, I do not have commit access, so someone may have to arrange for that ...

Nov 10 2020, 2:38 PM · Restricted Project, Restricted Project

Nov 1 2020

mnauw updated the diff for D90534: [clang-format] Add new option PenaltyIndentedWhitespace.

Patch updated to include unit test and documentation changes (and to use full diff).

Nov 1 2020, 5:22 AM · Restricted Project, Restricted Project
mnauw added inline comments to D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter.
Nov 1 2020, 2:16 AM · Restricted Project, Restricted Project

Oct 31 2020

mnauw requested review of D90534: [clang-format] Add new option PenaltyIndentedWhitespace.
Oct 31 2020, 8:09 AM · Restricted Project, Restricted Project
mnauw requested review of D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter.
Oct 31 2020, 8:02 AM · Restricted Project, Restricted Project

Apr 18 2020

mnauw added a comment to D77938: [clangd] Extend YAML Serialization.

I do not have commit access, so it would be helpful that you land this (and the other) ;-)

Apr 18 2020, 4:18 AM · Restricted Project, Restricted Project

Apr 17 2020

mnauw updated the diff for D77938: [clangd] Extend YAML Serialization.

As suggested, existing (YAML) Serialization test has been extended.

Apr 17 2020, 4:50 AM · Restricted Project, Restricted Project

Apr 11 2020

mnauw added a comment to D77938: [clangd] Extend YAML Serialization.

This was previously part of D77385. Rather than a separate file (which seems a bit tricky), the test YAML has simply been included in the unit test itself.

Apr 11 2020, 3:10 AM · Restricted Project, Restricted Project
mnauw created D77938: [clangd] Extend YAML Serialization.
Apr 11 2020, 3:10 AM · Restricted Project, Restricted Project

Apr 10 2020

mnauw added a comment to D77385: [clangd] Add index export to dexp.

As suggested, I will provide the YAMLSerialization changes in a separate patch. Regarding test for that, I was thinking of some running some "simple/mock YAML data" through some load and save cycle(s). I presume a separate YAML file (in e.g. test/Inputs) is best for that?

Apr 10 2020, 6:25 AM · Restricted Project, Restricted Project
mnauw updated the diff for D77385: [clangd] Add index export to dexp.
Apr 10 2020, 6:25 AM · Restricted Project, Restricted Project

Apr 4 2020

mnauw updated the diff for D77385: [clangd] Add index export to dexp.
Apr 4 2020, 4:08 AM · Restricted Project, Restricted Project

Apr 3 2020

mnauw added a comment to D77385: [clangd] Add index export to dexp.

Thanks for having a look at this patch. My use-case/goal would be to have a way to run/do a command that reads some index and dumps it (in e.g. YAML) to (e.g.) stdout. That way it can be inspected/viewed all at once by plain viewer. And not only symbols, refs, but also recorded paths (that form the include-graph). The latter in particular was/is useful when investigating some not-entirely-consistent symlink-resolution issues. The goal is not necessarily a separate binary, so if it's ok to extend dexp to achieve the former (e.g. by adding option(s)) then I can also update to patch that way accordingly.

Apr 3 2020, 11:20 AM · Restricted Project, Restricted Project
mnauw created D77385: [clangd] Add index export to dexp.
Apr 3 2020, 6:24 AM · Restricted Project, Restricted Project