This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Extend YAML Serialization

Authored by mnauw on Apr 11 2020, 2:42 AM.

Diff Detail

Event Timeline

mnauw created this revision.Apr 11 2020, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2020, 2:42 AM
mnauw added a comment.Apr 11 2020, 2:46 AM

This was previously part of D77385. Rather than a separate file (which seems a bit tricky), the test YAML has simply been included in the unit test itself.

Thanks for doing this!

1 ↗(On Diff #256757)

Ack, sorry for not mentioning this in the previous review.
The YAML stuff is tested mixed together with the binary format stuff in SerializationTests.cpp.
Is it possible to extend the YAML literal in that file with a synthetic Source and Cmd entry, and test it in a similar way?

mnauw updated this revision to Diff 258292.Apr 17 2020, 4:46 AM

As suggested, existing (YAML) Serialization test has been extended.

sammccall accepted this revision.Apr 17 2020, 7:41 AM

Thank you!

Do you have commit access, or would you like me to land this and D78038 for you?

This revision is now accepted and ready to land.Apr 17 2020, 7:41 AM
mnauw added a comment.Apr 18 2020, 4:14 AM

I do not have commit access, so it would be helpful that you land this (and the other) ;-)

This revision was automatically updated to reflect the committed changes.

Done, thanks for the contributions!
Feel free to apply for commit access at any point if you plan to work more on clangd or other LLVM stuff.