This is an archive of the discontinued LLVM Phabricator instance.

Differential D77927

[MLIR] CMake cleanup for mlir-opt
ClosedPublic

Authored by stephenneuendorffer on Apr 10 2020, 6:22 PM.

Details

Reviewers
None
Commits
rG4956871c0e6f: [MLIR] CMake cleanup for mlir-opt
Summary

A few libraries which are also Dialect libraries where independently
in the link line for mlir-opt. Remove them.

Depends on D77926

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Apr 10 2020, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 6:22 PM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 13 others. · View Herald Transcript
mehdi_amini added inline comments.Apr 10 2020, 6:34 PM
mlir/tools/mlir-opt/CMakeLists.txt
10

why is the "transforms" library parts of the "dialect library"?

Harbormaster completed remote builds in B52780: Diff 256733.Apr 10 2020, 7:24 PM
stephenneuendorffer marked an inline comment as done.Apr 11 2020, 9:54 PM
stephenneuendorffer added inline comments.
mlir/tools/mlir-opt/CMakeLists.txt
10

Currently all the libraries under lib/Dialect are "Dialect Libraries". We could make this more fine-grained, I suppose.
"Dialect Op Libraries" "Dialect Transform Libraries" "Dialect Analysis Libraries" "Dialect EDSC libraries" "DialectSerializationLibraries"?

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2020, 10:24 PM
Closed by commit rG4956871c0e6f: [MLIR] CMake cleanup for mlir-opt (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added inline comments.Apr 12 2020, 10:09 AM
mlir/tools/mlir-opt/CMakeLists.txt
10

Oh right it makes sense, MLIR_DIALECT_LIBS includes everything, if someone wants to depend on finer grain they can use individual targets.
Thanks!

Revision Contents

PathSize
mlir/
tools/
mlir-opt/
3 lines

Diff 256822

mlir/tools/mlir-opt/CMakeLists.txt

set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
null.cpp null.cpp
) )
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS) get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
set(LIBS set(LIBS
${dialect_libs} ${dialect_libs}
${conversion_libs} ${conversion_libs}
MLIRLoopOpsTransforms
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

why is the "transforms" library parts of the "dialect library"?

mehdi_amini: why is the "transforms" library parts of the "dialect library"?
stephenneuendorfferAuthorUnsubmitted
Done
ReplyInline Actions

Currently all the libraries under lib/Dialect are "Dialect Libraries". We could make this more fine-grained, I suppose.
"Dialect Op Libraries" "Dialect Transform Libraries" "Dialect Analysis Libraries" "Dialect EDSC libraries" "DialectSerializationLibraries"?

stephenneuendorffer: Currently all the libraries under lib/Dialect are "Dialect Libraries". We could make this more…
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

Oh right it makes sense, MLIR_DIALECT_LIBS includes everything, if someone wants to depend on finer grain they can use individual targets.
Thanks!

mehdi_amini: Oh right it makes sense, MLIR_DIALECT_LIBS includes everything, if someone wants to depend on…
MLIRLoopAnalysis MLIRLoopAnalysis
MLIRAffineTransformsTestPasses MLIRAffineTransformsTestPasses
MLIRAnalysis MLIRAnalysis
MLIRDialect MLIRDialect
MLIREDSC MLIREDSC
MLIROptLib MLIROptLib
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRSPIRV
MLIRSPIRVTestPasses MLIRSPIRVTestPasses
MLIRSPIRVTransforms
MLIRTransforms MLIRTransforms
MLIRTransformUtils MLIRTransformUtils
MLIRTestDialect MLIRTestDialect
MLIRTestIR MLIRTestIR
MLIRTestPass MLIRTestPass
MLIRTestTransforms MLIRTestTransforms
MLIRSupport MLIRSupport
MLIRIR MLIRIR
Show All 20 Lines