This is an archive of the discontinued LLVM Phabricator instance.

Differential D77926

[MLIR] add cmake abstraction for translation libraries
ClosedPublic

Authored by stephenneuendorffer on Apr 10 2020, 6:21 PM.

Details

Reviewers
mehdi_amini
Commits
rG4c18e1d3afef: [MLIR] add cmake abstraction for translation libraries

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Apr 10 2020, 6:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2020, 6:22 PM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 14 others. · View Herald Transcript
stephenneuendorffer added a child revision: D77927: [MLIR] CMake cleanup for mlir-opt.Apr 10 2020, 6:22 PM
mehdi_amini accepted this revision.Apr 10 2020, 6:35 PM
This revision is now accepted and ready to land.Apr 10 2020, 6:35 PM
Harbormaster completed remote builds in B52779: Diff 256732.Apr 10 2020, 7:57 PM
Closed by commit rG4c18e1d3afef: [MLIR] add cmake abstraction for translation libraries (authored by stephenneuendorffer). · Explain WhyApr 11 2020, 10:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
cmake/
modules/
6 lines
lib/
Target/
10 lines
tools/
mlir-translate/
7 lines

Diff 256821

mlir/cmake/modules/AddMLIR.cmake

Show All 40 Linesfunction(add_mlir_dialect_library name)
add_mlir_library(${ARGV}) add_mlir_library(${ARGV})
endfunction(add_mlir_dialect_library) endfunction(add_mlir_dialect_library)
# Declare the library associated with a conversion. # Declare the library associated with a conversion.
function(add_mlir_conversion_library name) function(add_mlir_conversion_library name)
set_property(GLOBAL APPEND PROPERTY MLIR_CONVERSION_LIBS ${name}) set_property(GLOBAL APPEND PROPERTY MLIR_CONVERSION_LIBS ${name})
add_mlir_library(${ARGV}) add_mlir_library(${ARGV})
endfunction(add_mlir_conversion_library) endfunction(add_mlir_conversion_library)
# Declare the library associated with a translation.
function(add_mlir_translation_library name)
set_property(GLOBAL APPEND PROPERTY MLIR_TRANSLATION_LIBS ${name})
add_mlir_library(${ARGV})
endfunction(add_mlir_translation_library)

mlir/lib/Target/CMakeLists.txt

add_mlir_library(MLIRTargetLLVMIRModuleTranslation add_mlir_translation_library(MLIRTargetLLVMIRModuleTranslation
LLVMIR/DebugTranslation.cpp LLVMIR/DebugTranslation.cpp
LLVMIR/ModuleTranslation.cpp LLVMIR/ModuleTranslation.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
target_link_libraries(MLIRTargetLLVMIRModuleTranslation target_link_libraries(MLIRTargetLLVMIRModuleTranslation
PUBLIC PUBLIC
MLIRLLVMIR MLIRLLVMIR
MLIRLLVMIRTransforms MLIRLLVMIRTransforms
LLVMCore LLVMCore
LLVMIRReader LLVMIRReader
LLVMSupport LLVMSupport
LLVMTransformUtils LLVMTransformUtils
MLIRTranslation MLIRTranslation
) )
add_mlir_library(MLIRTargetAVX512 add_mlir_translation_library(MLIRTargetAVX512
LLVMIR/LLVMAVX512Intr.cpp LLVMIR/LLVMAVX512Intr.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
DEPENDS DEPENDS
MLIRLLVMAVX512ConversionsIncGen MLIRLLVMAVX512ConversionsIncGen
) )
target_link_libraries(MLIRTargetAVX512 target_link_libraries(MLIRTargetAVX512
PUBLIC PUBLIC
MLIRIR MLIRIR
MLIRLLVMAVX512 MLIRLLVMAVX512
MLIRLLVMIR MLIRLLVMIR
MLIRTargetLLVMIRModuleTranslation MLIRTargetLLVMIRModuleTranslation
) )
add_mlir_library(MLIRTargetLLVMIR add_mlir_translation_library(MLIRTargetLLVMIR
LLVMIR/ConvertFromLLVMIR.cpp LLVMIR/ConvertFromLLVMIR.cpp
LLVMIR/ConvertToLLVMIR.cpp LLVMIR/ConvertToLLVMIR.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
) )
target_link_libraries(MLIRTargetLLVMIR target_link_libraries(MLIRTargetLLVMIR
PUBLIC PUBLIC
MLIRTargetLLVMIRModuleTranslation MLIRTargetLLVMIRModuleTranslation
) )
add_mlir_library(MLIRTargetNVVMIR add_mlir_translation_library(MLIRTargetNVVMIR
LLVMIR/ConvertToNVVMIR.cpp LLVMIR/ConvertToNVVMIR.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
target_link_libraries(MLIRTargetNVVMIR target_link_libraries(MLIRTargetNVVMIR
PUBLIC PUBLIC
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRNVVMIR MLIRNVVMIR
MLIRTargetLLVMIRModuleTranslation MLIRTargetLLVMIRModuleTranslation
) )
add_mlir_library(MLIRTargetROCDLIR add_mlir_translation_library(MLIRTargetROCDLIR
LLVMIR/ConvertToROCDLIR.cpp LLVMIR/ConvertToROCDLIR.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
target_link_libraries(MLIRTargetROCDLIR target_link_libraries(MLIRTargetROCDLIR
PUBLIC PUBLIC
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRROCDLIR MLIRROCDLIR
MLIRTargetLLVMIRModuleTranslation MLIRTargetLLVMIRModuleTranslation
) )

mlir/tools/mlir-translate/CMakeLists.txt

get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
get_property(translation_libs GLOBAL PROPERTY MLIR_TRANSLATION_LIBS)
set(LIBS set(LIBS
${dialect_libs} ${dialect_libs}
${translation_libs}
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSPIRVSerialization
MLIRTargetAVX512
MLIRTargetLLVMIR
MLIRTargetNVVMIR
MLIRTargetROCDLIR
MLIRTranslation MLIRTranslation
MLIRSupport MLIRSupport
) )
add_llvm_tool(mlir-translate add_llvm_tool(mlir-translate
mlir-translate.cpp mlir-translate.cpp
) )
llvm_update_compile_flags(mlir-translate) llvm_update_compile_flags(mlir-translate)
target_link_libraries(mlir-translate PRIVATE MLIRIR MLIRTranslation ${LIBS} LLVMSupport) target_link_libraries(mlir-translate PRIVATE MLIRIR MLIRTranslation ${LIBS} LLVMSupport)