Page MenuHomePhabricator
Differential D77832

Allow single-bit integer types to have signs. A signed one bit integer is either 0 or -1.
ClosedPublic
Actions

Authored by lattner on Apr 9 2020, 2:58 PM.

Details

Reviewers
rriddle
antiagainst
Commits
rGab64fd39d252: Allow single-bit integer types to have signs. A signed one bit integer is…

Diff Detail

Event Timeline

lattner created this revision.Apr 9 2020, 2:58 PM
Herald added a reviewer: rriddle. · View Herald TranscriptApr 9 2020, 2:58 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, frgossen, grosul1 and 12 others. · View Herald Transcript
lattner added a reviewer: antiagainst.Apr 9 2020, 2:59 PM
rriddle accepted this revision.Apr 9 2020, 3:10 PM
rriddle added inline comments.
mlir/test/IR/attribute.mlir
84

nit: 1 : ui1

to match the output

This revision is now accepted and ready to land.Apr 9 2020, 3:10 PM
lattner marked 2 inline comments as done.Apr 9 2020, 3:24 PM
lattner added inline comments.
mlir/test/IR/attribute.mlir
84

Sorry I didn't see this comment (still relatively new to phabricator). I'll push a follow up commit with this tweak. Thank you for the review!

lattner closed this revision.Apr 9 2020, 3:27 PM
lattner marked an inline comment as done.
Harbormaster completed remote builds in B52580: Diff 256419.Apr 9 2020, 4:02 PM

Revision Contents
Changeset List

PathSize
mlir/
lib/
IR/
11 lines
2 lines
test/
IR/
7 lines
8 lines

Diff 256419

View Options

mlir/lib/IR/AsmPrinter.cpp

Loading...
View Options

mlir/lib/IR/StandardTypes.cpp

Loading...
View Options

mlir/test/IR/attribute.mlir

Loading...
View Options

mlir/test/IR/invalid.mlir

Loading...