Page MenuHomePhabricator

Allow single-bit integer types to have signs. A signed one bit integer is either 0 or -1.
ClosedPublic

Authored by lattner on Apr 9 2020, 2:58 PM.

Diff Detail

Event Timeline

lattner created this revision.Apr 9 2020, 2:58 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle accepted this revision.Apr 9 2020, 3:10 PM
rriddle added inline comments.
mlir/test/IR/attribute.mlir
84

nit: 1 : ui1

to match the output

This revision is now accepted and ready to land.Apr 9 2020, 3:10 PM
lattner marked 2 inline comments as done.Apr 9 2020, 3:24 PM
lattner added inline comments.
mlir/test/IR/attribute.mlir
84

Sorry I didn't see this comment (still relatively new to phabricator). I'll push a follow up commit with this tweak. Thank you for the review!

lattner closed this revision.Apr 9 2020, 3:27 PM
lattner marked an inline comment as done.