This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Mark ClassID::getID as LLVM_EXTERNAL_VISIBILITY to ensure only one version exists
ClosedPublic

Authored by rriddle on Apr 8 2020, 4:35 PM.

Details

Summary

ClassID is used as a type id and must be unique in the face of shared libraries to ensure correctness. This fixes failures related to BUILD_SHARED_LIBs on macos.

Diff Detail

Event Timeline

rriddle created this revision.Apr 8 2020, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 4:35 PM
mehdi_amini accepted this revision.Apr 8 2020, 4:46 PM
This revision is now accepted and ready to land.Apr 8 2020, 4:46 PM
jroelofs accepted this revision.Apr 8 2020, 4:54 PM

LGTM

This revision was automatically updated to reflect the committed changes.