This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Remove calls to isScalable from Transforms

Authored by ctetreau on Apr 8 2020, 2:48 PM.

Diff Detail

Event Timeline

ctetreau created this revision.Apr 8 2020, 2:48 PM
Herald added a project: Restricted Project. · View Herald Transcript

While immediate feedback would be greatly appreciated, this commit won't actually build until D77587 is merged. I'll ping the thread when this happens if this commit hasn't been accepted yet.

efriedma added inline comments.Apr 10 2020, 2:37 PM

This doesn't appear to be equivalent.

ctetreau marked an inline comment as done.Apr 10 2020, 2:43 PM
ctetreau added inline comments.

(NOT ((is vector) AND (is scalable))) => true for all values except scalable vectors
(is fixed width vector) => true only for fixed width vectors

I'll fix it

ctetreau updated this revision to Diff 257152.Apr 13 2020, 4:47 PM

address code review issues

ctetreau updated this revision to Diff 257481.Apr 14 2020, 1:42 PM

Catch straggler

This revision is now accepted and ready to land.Apr 14 2020, 2:22 PM
ctetreau updated this revision to Diff 257561.Apr 14 2020, 4:58 PM

catch straggler

This revision was automatically updated to reflect the committed changes.