Page MenuHomePhabricator

[WebAssembly][MC] Use StringRef over std::string pointer
ClosedPublic

Authored by sbc100 on Apr 7 2020, 12:27 PM.

Diff Detail

Event Timeline

sbc100 created this revision.Apr 7 2020, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2020, 12:27 PM
dblaikie accepted this revision.Apr 7 2020, 1:01 PM

Looks good - thanks!

This revision is now accepted and ready to land.Apr 7 2020, 1:01 PM
This revision was automatically updated to reflect the committed changes.
bcain added a subscriber: bcain.Apr 9 2020, 6:44 AM
bcain added inline comments.
llvm/include/llvm/MC/MCSymbolWasm.h
86

This block could instead be written as return ImportName.getValueOr(getName());

[not that you need to revisit the code, just a suggestion for next time]