Page MenuHomePhabricator

[libc++] Update the documentation for running Lit to reflect reality
ClosedPublic

Authored by ldionne on Apr 7 2020, 12:20 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rG82bec931814d: [libc++] Update the documentation for running Lit to reflect reality
Summary

Our documentation for running LIT is basically wrong, since it doesn't
mention llvm-lit, and nothing works without it. Note that this
documentation improvement reflects the current reality outside of
the recent efforts on improving the test suite. My goal is to document
the current way of running the test suite, so that everybody agrees on
how things currently work. As the configuration system for libc++ gets
simplified, we can come back and keep this documentation up to date to
reflect those changes.

Diff Detail

Event Timeline

ldionne created this revision.Apr 7 2020, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2020, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Adding folks who might be interested. I'm especially interested to know if anyone's workflow differs from what I'm documenting in my changes, and if so, how does it differ.

Yes! I can attest that the old text wasted a bunch of my time and the new text is what works.

LGTM. Thanks for all your work on this @ldionne.

ldionne accepted this revision as: Restricted Project.Apr 8 2020, 12:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 12:30 PM
This revision was automatically updated to reflect the committed changes.