This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Modify library linkage to resolve PR45453
AbandonedPublic

Authored by jdoerfert on Apr 7 2020, 8:40 AM.

Download Raw Diff

Details

Reviewers

sylvestre.ledru
lebedev.ri

Summary

This is a try that works locally but the problem did not occur locally
(even though shared libraries were enabled).

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	120 ms	lldb-unit.Host/_/HostTests::Unknown Unit Message ("")

Event Timeline

jdoerfert created this revision.Apr 7 2020, 8:40 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2020, 8:40 AM

Herald added subscribers: guansong, bollu, yaxunl, mgorny. · View Herald Transcript

jdoerfert retitled this revision from [OpenMP] Modify library linkage to resolved PR28433 to [OpenMP] Modify library linkage to resolve PR28433.Apr 7 2020, 8:45 AM

jdoerfert retitled this revision from [OpenMP] Modify library linkage to resolve PR28433 to [OpenMP] Modify library linkage to resolve PR45453.Apr 7 2020, 9:02 AM

Harbormaster failed remote builds in B52161: Diff 255690!Apr 7 2020, 9:45 AM

This doesn't work either :(

Revision Contents

Path

Size

clang/

lib/

ASTMatchers/

CMakeLists.txt

3 lines

Diff 255690

clang/lib/ASTMatchers/CMakeLists.txt

	add_subdirectory(Dynamic)			add_subdirectory(Dynamic)

	set(LLVM_LINK_COMPONENTS			set(LLVM_LINK_COMPONENTS
	Support			Support
				FrontendOpenMP
	)			)

	add_clang_library(clangASTMatchers			add_clang_library(clangASTMatchers
	ASTMatchFinder.cpp			ASTMatchFinder.cpp
	ASTMatchersInternal.cpp			ASTMatchersInternal.cpp
	GtestMatchers.cpp			GtestMatchers.cpp

	LINK_LIBS			LINK_LIBS
	clangAST			clangAST
	clangBasic			clangBasic
	clangLex			clangLex
	)			)

	target_link_libraries(clangASTMatchers PUBLIC LLVMFrontendOpenMP)			target_link_libraries(clangASTMatchers INTERFACE LLVMFrontendOpenMP)