Page MenuHomePhabricator

Add map-type check for target and target data directive
ClosedPublic

Authored by cchen on Apr 6 2020, 12:52 PM.

Diff Detail

Event Timeline

cchen created this revision.Apr 6 2020, 12:52 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
cchen updated this revision to Diff 255481.Apr 6 2020, 1:52 PM

Do not use lint on test

ABataev added inline comments.Apr 6 2020, 2:06 PM
clang/lib/Sema/SemaOpenMP.cpp
17001–17038
  1. Why 2 similar checks?
  2. Some of the logical conditions can be replaced with isOpenMPTagetExecutableDirective() or similar.
cchen marked an inline comment as done.Apr 6 2020, 2:14 PM
cchen added inline comments.
clang/lib/Sema/SemaOpenMP.cpp
17001–17038

I messed up the code with arc, I'll fix it. thanks

cchen updated this revision to Diff 255497.Apr 6 2020, 2:40 PM

Reuse existing function for target/target data check

ABataev accepted this revision.Apr 6 2020, 2:45 PM

LG, thanks!

This revision is now accepted and ready to land.Apr 6 2020, 2:45 PM
cchen added a comment.Apr 6 2020, 3:06 PM

@ABataev , can you land it for me when you have time? thanks

Sure, will do it later

This revision was automatically updated to reflect the committed changes.