Page MenuHomePhabricator

[DebugInfo]: Allow DwarfCompileUnit to have line table symbol
ClosedPublic

Authored by SouraVX on Apr 5 2020, 1:34 AM.

Details

Summary

Previously line table symbol was represented as DIE::value_iterator inside DwarfCompileUnit and subsequent function intStmtList was used to create a local MCSymbol to initialize it.

This patch removes DIE::value_iterator from DwarfCompileUnit and intoduce MCSymbol for representing this units symbol for debug_line section. As a result applyStmtList is also modified to utilize this. Further more a helper function getLineTableStartSym is also introduced to get this symbol, this would be used by clients which need to access this line table, i.e debug_macro.

This patch is based on @dblaikie comment https://reviews.llvm.org/D72828#1958625 on D72828
Testing - No regression found on trunk.

Diff Detail

Event Timeline

SouraVX created this revision.Apr 5 2020, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2020, 1:34 AM
SouraVX edited the summary of this revision. (Show Details)Apr 5 2020, 1:45 AM
dblaikie accepted this revision.Apr 5 2020, 11:00 AM

Looks good - thanks!

This revision is now accepted and ready to land.Apr 5 2020, 11:00 AM
This revision was automatically updated to reflect the committed changes.