This is an archive of the discontinued LLVM Phabricator instance.

[LangRef] update text for shufflevector
ClosedPublic

Authored by spatel on Apr 3 2020, 7:19 AM.

Details

Summary

D72467 updated the shufflevector instruction to include a constant mask rather than a mask operand. The LangRef text was vague enough to still make sense, but it would be better to update here too, so there's no confusion about valid mask values. The text here is mostly copied from the documentation code comments for "class ShuffleVectorInst".

Diff Detail

Event Timeline

spatel created this revision.Apr 3 2020, 7:19 AM

Mentioning "UndefMaskElem" probably doesn't make sense. Maybe should be "undef"?

spatel updated this revision to Diff 255030.Apr 4 2020, 6:12 AM

Patch updated:
Rearranged text a bit more and removed reference to the 'UndefMaskElem' code constant.

This version lost the "constant integer or undef values" bit?

spatel updated this revision to Diff 255721.Apr 7 2020, 10:38 AM

Patch updated:
Restore description of constant mask elements as integer or undef. That seemed redundant to me before, but it's better to state that explicitly, so we don't let weird stuff like constant expressions into the picture.

This revision is now accepted and ready to land.Apr 7 2020, 10:51 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2020, 6:28 AM