This is an archive of the discontinued LLVM Phabricator instance.

Differential D77375

[compiler-rt] Don't print warning about missing testingsupport if not including tests
ClosedPublic

Authored by tambre on Apr 3 2020, 2:22 AM.

Details

Reviewers
samsonov
vitalybuka
Commits
rG3e9d074dea36: [compiler-rt] Don't print warning about missing testingsupport if not including…

Diff Detail

Event Timeline

tambre created this revision.Apr 3 2020, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2020, 2:22 AM
Herald added subscribers: Restricted Project, mgorny, dberris. · View Herald Transcript
Harbormaster completed remote builds in B51601: Diff 254732.Apr 3 2020, 3:11 AM
vitalybuka accepted this revision.Apr 3 2020, 4:15 AM
This revision is now accepted and ready to land.Apr 3 2020, 4:15 AM
tambre added a comment.Apr 3 2020, 4:37 AM

Please land this for me. I lack commit privileges. :)

tambre added a comment.Apr 8 2020, 2:27 AM

ping

Closed by commit rG3e9d074dea36: [compiler-rt] Don't print warning about missing testingsupport if not including… (authored by tambre, committed by vitalybuka). · Explain WhyApr 9 2020, 2:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 256224

compiler-rt/cmake/Modules/CompilerRTUtils.cmake

Show First 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (LLVM_CONFIG_PATH)
set(COMPILER_RT_HAS_LLVMTESTINGSUPPORT FALSE) set(COMPILER_RT_HAS_LLVMTESTINGSUPPORT FALSE)
execute_process( execute_process(
COMMAND ${LLVM_CONFIG_PATH} "--ldflags" "--libs" "testingsupport" COMMAND ${LLVM_CONFIG_PATH} "--ldflags" "--libs" "testingsupport"
RESULT_VARIABLE HAD_ERROR RESULT_VARIABLE HAD_ERROR
OUTPUT_VARIABLE CONFIG_OUTPUT OUTPUT_VARIABLE CONFIG_OUTPUT
ERROR_QUIET) ERROR_QUIET)
if (HAD_ERROR) if (HAD_ERROR)
message(WARNING "llvm-config finding testingsupport failed with status ${HAD_ERROR}") message(WARNING "llvm-config finding testingsupport failed with status ${HAD_ERROR}")
else() elseif(COMPILER_RT_INCLUDE_TESTS)
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CONFIG_OUTPUT}) string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CONFIG_OUTPUT})
list(GET CONFIG_OUTPUT 0 LDFLAGS) list(GET CONFIG_OUTPUT 0 LDFLAGS)
list(GET CONFIG_OUTPUT 1 LIBLIST) list(GET CONFIG_OUTPUT 1 LIBLIST)
if (LIBLIST STREQUAL "") if (LIBLIST STREQUAL "")
message(WARNING "testingsupport library not installed, some tests will be skipped") message(WARNING "testingsupport library not installed, some tests will be skipped")
else() else()
file(TO_CMAKE_PATH "${LDFLAGS}" LDFLAGS) file(TO_CMAKE_PATH "${LDFLAGS}" LDFLAGS)
file(TO_CMAKE_PATH "${LIBLIST}" LIBLIST) file(TO_CMAKE_PATH "${LIBLIST}" LIBLIST)
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines