This is an archive of the discontinued LLVM Phabricator instance.

Differential D77345

Teach the stripNonLineTableDebugInfo pass about the llvm.dbg.label intrinsic.
ClosedPublic

Authored by aprantl on Apr 2 2020, 4:13 PM.

Details

Reviewers
steven_wu
vsk
friss
davide
Commits
rGe9e4035903f4: Teach the stripNonLineTableDebugInfo pass about the llvm.dbg.label intrinsic.
rG93fe58c9cf53: Teach the stripNonLineTableDebugInfo pass about the llvm.dbg.label intrinsic.
Summary

Debug info for labels is not generated at -gline-tables-only, so this pass should remove them.

Diff Detail

Event Timeline

aprantl created this revision.Apr 2 2020, 4:13 PM
Herald added subscribers: dexonsmith, hiraditya. · View Herald TranscriptApr 2 2020, 4:13 PM
vsk accepted this revision.Apr 2 2020, 4:16 PM

LGTM

This revision is now accepted and ready to land.Apr 2 2020, 4:16 PM
aprantl added a parent revision: D77343: Teach the stripNonLineTableDebugInfo pass about the llvm.dbg.addr intrinsic..Apr 2 2020, 4:50 PM
Closed by commit rG93fe58c9cf53: Teach the stripNonLineTableDebugInfo pass about the llvm.dbg.label intrinsic. (authored by aprantl). · Explain WhyApr 2 2020, 5:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2020, 5:55 PM

Revision Contents

PathSize
llvm/
lib/
IR/
1 line
test/
Transforms/
Util/
28 lines

Diff 254642

llvm/lib/IR/DebugInfo.cpp

Show First 20 Lines • Show All 602 Lines • ▼ Show 20 Lines if (auto *DbgVal = M.getFunction(Name)) {
while (!DbgVal->use_empty()) while (!DbgVal->use_empty())
cast<Instruction>(DbgVal->user_back())->eraseFromParent(); cast<Instruction>(DbgVal->user_back())->eraseFromParent();
DbgVal->eraseFromParent(); DbgVal->eraseFromParent();
Changed = true; Changed = true;
} }
}; };
RemoveUses("llvm.dbg.addr"); RemoveUses("llvm.dbg.addr");
RemoveUses("llvm.dbg.declare"); RemoveUses("llvm.dbg.declare");
RemoveUses("llvm.dbg.label");
RemoveUses("llvm.dbg.value"); RemoveUses("llvm.dbg.value");
// Delete non-CU debug info named metadata nodes. // Delete non-CU debug info named metadata nodes.
for (auto NMI = M.named_metadata_begin(), NME = M.named_metadata_end(); for (auto NMI = M.named_metadata_begin(), NME = M.named_metadata_end();
NMI != NME;) { NMI != NME;) {
NamedMDNode *NMD = &*NMI; NamedMDNode *NMD = &*NMI;
++NMI; ++NMI;
// Specifically keep dbg.cu around. // Specifically keep dbg.cu around.
▲ Show 20 Lines • Show All 845 Lines • Show Last 20 Lines

llvm/test/Transforms/Util/strip-nonlinetable-debuginfo-labels.ll

  • This file was added.
; RUN: opt -S -strip-nonlinetable-debuginfo %s -o - | FileCheck %s
; CHECK: define void @f()
define void @f() !dbg !4 {
entry:
; CHECK-NOT: llvm.dbg.label
call void @llvm.dbg.label(metadata !12), !dbg !11
ret void, !dbg !11
}
declare void @llvm.dbg.label(metadata)
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!7, !8, !9}
!llvm.ident = !{!10}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "LLVM", isOptimized: false, runtimeVersion: 0, emissionKind: 1, enums: !2)
!1 = !DIFile(filename: "f.c", directory: "/")
!2 = !{}
!4 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 1, type: !5, isLocal: false, isDefinition: true, scopeLine: 1, isOptimized: false, unit: !0, retainedNodes: !2)
!5 = !DISubroutineType(types: !6)
!6 = !{null}
!7 = !{i32 2, !"Dwarf Version", i32 2}
!8 = !{i32 2, !"Debug Info Version", i32 3}
!9 = !{i32 1, !"PIC Level", i32 2}
!10 = !{!"LLVM"}
!11 = !DILocation(line: 1, column: 24, scope: !4)
; CHECK-NOT: DILabel
!12 = !DILabel(scope: !4, name: "entry", file: !1, line: 1)