This is an archive of the discontinued LLVM Phabricator instance.

Differential D77011

[AMDGPU] Drop const for value that is copied (NFC_.
ClosedPublic

Authored by fhahn on Mar 29 2020, 5:25 AM.

Details

Reviewers
rampitec
Commits
rGc3b03f3d0c35: [AMDGPU] Drop const for value that is copied (NFC).
Summary

This fixes

warning: loop variable 'Def' of type 'const llvm::Register' creates a copy from type 'const llvm::Register' [-Wrange-loop-analysis]

llvm::Register just contains a single unsigned and should be copied.

Diff Detail

Unit TestsFailed

TimeTest
190 mslldb-unit.Host/_/HostTests::Unknown Unit Message ("")

Event Timeline

fhahn created this revision.Mar 29 2020, 5:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2020, 5:25 AM
Herald added subscribers: kerbowa, hiraditya, t-tye and 8 others. · View Herald Transcript
Harbormaster failed remote builds in B50859: Diff 253413!Mar 29 2020, 7:27 AM
rampitec accepted this revision.Mar 29 2020, 12:14 PM
This revision is now accepted and ready to land.Mar 29 2020, 12:14 PM
Closed by commit rGc3b03f3d0c35: [AMDGPU] Drop const for value that is copied (NFC). (authored by fhahn). · Explain WhyMar 30 2020, 3:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
2 lines

Diff 253413

llvm/lib/Target/AMDGPU/SIPostRABundler.cpp

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
bool SIPostRABundler::isDependentLoad(const MachineInstr &MI) const { bool SIPostRABundler::isDependentLoad(const MachineInstr &MI) const {
if (!MI.mayLoad()) if (!MI.mayLoad())
return false; return false;
for (const MachineOperand &Op : MI.explicit_operands()) { for (const MachineOperand &Op : MI.explicit_operands()) {
if (!Op.isReg()) if (!Op.isReg())
continue; continue;
Register Reg = Op.getReg(); Register Reg = Op.getReg();
for (const Register Def : Defs) for (Register Def : Defs)
if (TRI->regsOverlap(Reg, Def)) if (TRI->regsOverlap(Reg, Def))
return true; return true;
} }
return false; return false;
} }
bool SIPostRABundler::runOnMachineFunction(MachineFunction &MF) { bool SIPostRABundler::runOnMachineFunction(MachineFunction &MF) {
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines