This is an archive of the discontinued LLVM Phabricator instance.

[clang][llvm] Interface Stubs new yaml file format changes.
ClosedPublic

Authored by plotfi on Mar 28 2020, 1:11 AM.

Details

Summary

These file format changes have been a long time coming. Essentially instead of a yaml map mapping trait we now have a sequence. This generally makes the format work better for cases where the symbol list is empty.

Diff Detail

Event Timeline

plotfi created this revision.Mar 28 2020, 1:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2020, 1:11 AM
plotfi updated this revision to Diff 253360.Mar 28 2020, 10:15 AM

Changing some of the version checks. I don't think we need to have rigid checks considering this format is experimental.

Please address the linter warnings. I think that adding an additional test to demonstrate that the experimental-ifs-version-v1 is properly diagnosed is a good idea. LGTM other than that.

plotfi updated this revision to Diff 253367.Mar 28 2020, 11:30 AM

fixing linter errors

plotfi updated this revision to Diff 253369.Mar 28 2020, 11:42 AM

Adding a better test to check the deprecated v1 format.

plotfi updated this revision to Diff 254075.Mar 31 2020, 7:20 PM

Updating to change im about to land, to see what precommit changes show.

plotfi updated this revision to Diff 254080.Mar 31 2020, 8:39 PM

Trying to fix precommit / clang tidy checks.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2020, 7:53 AM
This revision was automatically updated to reflect the committed changes.