This is an archive of the discontinued LLVM Phabricator instance.

[GVN] Make GVN aware of aligned_alloc
ClosedPublic

Authored by bondhugula on Mar 28 2020, 12:30 AM.

Details

Summary

Make the GVN pass aware of aligned_alloc. There don't appear to be any
GVN test cases for malloc - this change is trivial and along the
same lines malloc/alloca are treated; a test case could be added when
it's added for the former.

Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

Depends on D76974.

Diff Detail

Event Timeline

bondhugula created this revision.Mar 28 2020, 12:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2020, 12:30 AM
bondhugula edited the summary of this revision. (Show Details)Mar 28 2020, 1:17 AM

Add test case

Add test case (commit id change on rebase)

xbolva00 accepted this revision.Mar 30 2020, 4:08 PM

Prefix patch with [GVN] please.

OK.

This revision is now accepted and ready to land.Mar 30 2020, 4:08 PM

Prefix patch with [GVN] please.

OK.

Sure - does the prefix tag trigger any auto testing? GVN's already in the title.

No, it does not. However, it is a good practise to do so. :) in LLVM we usually prefix patches with pass name like GVN, InstCombine, etc..

bondhugula retitled this revision from Make GVN aware of aligned_alloc to [GVN] Make GVN aware of aligned_alloc.Mar 31 2020, 10:49 AM
This revision was automatically updated to reflect the committed changes.