[test-suite] Add support for Hexagon

[bcain]

Summary

• add hexagon to DetectArchitecture
• disable MiBench, DOE-ProxyApps-C* tests currently unable to support

[bcain]

Accidentally omitted context lines w/previous patch

[bcain]

This is my first change to the test-suite, let me know if I'm doing this right. :)

[lebedev.ri]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

Can you please submit this as a pull request upstream?

[bcain]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

Oh, you bet! I didn't know we could use PRs.

There's been a few threads and I've only skimmed them. Now that you mention it I might've seen one that mentioned test-suite and PRs.

[lebedev.ri]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

I'm not sure what you mean.
I was only talking about MicroBenchmarks/libs/benchmark-1.3.0/* change,
about upstreaming it to https://github.com/google/benchmark

[bcain]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

Oh, whoops! Jumped the gun there.

Ok, will do. Once it lands there, do I make another review here to pull down the next release of that benchmark? Or does that happen naturally somehow?

[bcain]

Omitted out-of-scope change to benchmark's cycleclock.h

[lebedev.ri]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

Ok, will do. Once it lands there, do I make another review here to pull down the next release of that benchmark?

No, just cherry-pick that commit (note that there are at least 3 copies of benchmark within LLVM monorepo,
so you might want to patch them all at the same time..),
and add a comment about the cherry-pick into benchmark/README.llvm.

[bcain]

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

No, just cherry-pick that commit (note that there are at least 3 copies of benchmark within LLVM monorepo,

Ok, will do. I expect that it may be a while before I can contribute there but I'll get the process started.

[lebedev.ri]

MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h

85 ↗

(On Diff #254084)

Thanks!

[bcain]

In D76958#1957120, @bcain wrote:

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

Any thoughts on the remainder of the current state of the patch? Anything that should prevent me from merging this as-is?

@lebedev.ri @luismarques

[bcain]

In D76958#1958634, @bcain wrote:

In D76958#1957120, @bcain wrote:

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

Any thoughts on the remainder of the current state of the patch? Anything that should prevent me from merging this as-is?

@lebedev.ri @luismarques

Ping.

Any objections?

[sidneym]

Missing context but otherwise looks ok to me.

MultiSource/Benchmarks/CMakeLists.txt

 add_subdirectory(FreeBench)
 add_subdirectory(MallocBench)
 add_subdirectory(McCat)
-add_subdirectory(MiBench)
 add_subdirectory(NPB-serial)
 add_subdirectory(Olden)
 add_subdirectory(Prolangs-C)

 add_subdirectory(mediabench)
 add_subdirectory(nbench)
 add_subdirectory(sim)
-add_subdirectory(DOE-ProxyApps-C)
 add_subdirectory(Rodinia)
 
 if((NOT "${TARGET_OS}" STREQUAL "Darwin") OR (NOT "${ARCH}" STREQUAL "ARM"))

 add_subdirectory(Prolangs-C++)
 add_subdirectory(Bullet)
 add_subdirectory(tramp3d-v4)
-add_subdirectory(DOE-ProxyApps-C++)
+if(NOT "${ARCH}" STREQUAL "Hexagon")
+  add_subdirectory(DOE-ProxyApps-C++)
+  add_subdirectory(DOE-ProxyApps-C)
+  add_subdirectory(MiBench)
+endif()
 if(NOT "${ARCH}" STREQUAL "XCore")
   add_subdirectory(7zip)
   add_subdirectory(PAQ8p)

cmake/modules/DetectArchitecture.c

 const char *str = "ARCHITECTURE IS XCore";
 #elif defined(__i386__) || defined(__x86_64__)
 const char *str = "ARCHITECTURE IS x86";
+#elif defined(__hexagon__)
+const char *str = "ARCHITECTURE IS Hexagon";
 #endif
 
 int main(int argc, char **argv) {