This is an archive of the discontinued LLVM Phabricator instance.

Differential D76895

[mlir] Add exp2 conversion to llvm.intr.exp2
ClosedPublic

Authored by asmith on Mar 26 2020, 4:46 PM.

Details

Reviewers
ftynse

Diff Detail

Event Timeline

asmith created this revision.Mar 26 2020, 4:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 4:46 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 10 others. · View Herald Transcript
asmith added a reviewer: ftynse.Mar 26 2020, 4:48 PM
Harbormaster failed remote builds in B50642: Diff 253016!Mar 26 2020, 5:25 PM
asmith updated this revision to Diff 253028.Mar 26 2020, 6:31 PM

Adding a test

Herald added a subscriber: aartbik. · View Herald TranscriptMar 26 2020, 6:31 PM
ftynse accepted this revision.Mar 27 2020, 7:33 AM
ftynse added inline comments.
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1227

Nit: this pattern was changed to be using Exp2OpLowering = VectorConvertToLLVMPattern<Exp2Op, LLVM::Exp2Op>;

This revision is now accepted and ready to land.Mar 27 2020, 7:33 AM
asmith updated this revision to Diff 253407.Mar 29 2020, 1:12 AM
asmith closed this revision.Mar 29 2020, 1:25 AM

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
1 line
StandardOps/
IR/
8 lines
lib/
Conversion/
StandardToLLVM/
4 lines

Diff 253016

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Context not available.
def LLVM_CopySignOp : LLVM_BinarySameArgsIntrinsicOp<"copysign">; def LLVM_CopySignOp : LLVM_BinarySameArgsIntrinsicOp<"copysign">;
def LLVM_CosOp : LLVM_UnaryIntrinsicOp<"cos">; def LLVM_CosOp : LLVM_UnaryIntrinsicOp<"cos">;
def LLVM_ExpOp : LLVM_UnaryIntrinsicOp<"exp">; def LLVM_ExpOp : LLVM_UnaryIntrinsicOp<"exp">;
def LLVM_Exp2Op : LLVM_UnaryIntrinsicOp<"exp2">;
def LLVM_FAbsOp : LLVM_UnaryIntrinsicOp<"fabs">; def LLVM_FAbsOp : LLVM_UnaryIntrinsicOp<"fabs">;
def LLVM_FCeilOp : LLVM_UnaryIntrinsicOp<"ceil">; def LLVM_FCeilOp : LLVM_UnaryIntrinsicOp<"ceil">;
def LLVM_FMAOp : LLVM_TernarySameArgsIntrinsicOp<"fma">; def LLVM_FMAOp : LLVM_TernarySameArgsIntrinsicOp<"fma">;
Context not available.

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Context not available.
let summary = "base-e exponential of the specified value"; let summary = "base-e exponential of the specified value";
} }
//===----------------------------------------------------------------------===//
// ExpOp
//===----------------------------------------------------------------------===//
def Exp2Op : FloatUnaryOp<"exp2"> {
let summary = "base-2 exponential of the specified value";
}
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// ExtractElementOp // ExtractElementOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Context not available.

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Context not available.
struct ExpOpLowering : public VectorConvertToLLVMPattern<ExpOp, LLVM::ExpOp> { struct ExpOpLowering : public VectorConvertToLLVMPattern<ExpOp, LLVM::ExpOp> {
using Super::Super; using Super::Super;
}; };
struct Exp2OpLowering : public VectorConvertToLLVMPattern<Exp2Op, LLVM::Exp2Op> {
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-struct Exp2OpLowering : public VectorConvertToLLVMPattern<Exp2Op, LLVM::Exp2Op> {
+struct Exp2OpLowering
+    : public VectorConvertToLLVMPattern<Exp2Op, LLVM::Exp2Op> {
Lint: Pre-merge checks: clang-format: please reformat the code ``` -struct Exp2OpLowering : public…
ftynseUnsubmitted
Not Done
ReplyInline Actions

Nit: this pattern was changed to be using Exp2OpLowering = VectorConvertToLLVMPattern<Exp2Op, LLVM::Exp2Op>;

ftynse: Nit: this pattern was changed to be `using Exp2OpLowering = VectorConvertToLLVMPattern<Exp2Op…
using Super::Super;
};
struct LogOpLowering : public VectorConvertToLLVMPattern<LogOp, LLVM::LogOp> { struct LogOpLowering : public VectorConvertToLLVMPattern<LogOp, LLVM::LogOp> {
using Super::Super; using Super::Super;
}; };
Context not available.
DialectCastOpLowering, DialectCastOpLowering,
DivFOpLowering, DivFOpLowering,
ExpOpLowering, ExpOpLowering,
Exp2OpLowering,
LogOpLowering, LogOpLowering,
Log10OpLowering, Log10OpLowering,
Log2OpLowering, Log2OpLowering,
Context not available.