The tests referred to in Chapter 3 of the tutorial were missing from the tutorial test
directory; this adds those missing tests. This also cleans up some stale directory paths and code
snippets used throughout the tutorial.
Details
Details
- Reviewers
rriddle - Commits
- rGa0d5e5496621: [MLIR] Update tutorial to add missing tests and bring directory paths and code…
rGa6b427167e05: [MLIR] Update tutorial to add missing tests and bring directory paths and code…
rG495cf2729188: [MLIR] Update tutorial to add missing tests and bring directory paths and code…
rG46294ffd1c08: Unreachable (removed)
rG9cad0d090d33: Unreachable (removed)
rG01d781489e71: Unreachable (removed)
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/test/Examples/Toy/Ch3/transpose_transpose.toy | ||
---|---|---|
1 | Can you add a run of -opt to each of these tests? That should match with the instructions in the .md tutorial documents. |
This comment was removed by lucyrfox.
Comment Actions
Looks like you pushed a branch for this review to the repo somehow, I got this when git pulling just now:
From https://github.com/llvm/llvm-project
c196e2ca48b..21d50019ca8 master -> origin/master
- [new branch] arcpatch-D76809_2 -> origin/arcpatch-D76809_2 71c3f57326c..92d5c1be9ee release/10.x -> origin/release/10.x
Could you remove that branch again?
Comment Actions
Sorry about that - am working with an unfamiliar workflow that led me to a strange place... just deleted the branch but let me know if there's still any issue.
Can you add a run of -opt to each of these tests? That should match with the instructions in the .md tutorial documents.