Page MenuHomePhabricator

[libc++] Set filesystem test flags in a lit.local.cfg
ClosedPublic

Authored by ldionne on Mar 25 2020, 10:40 AM.

Details

Reviewers
EricWF
Group Reviewers
Restricted Project
Commits
rGd3a729ab247a: [libc++] Set filesystem test flags in a lit.local.cfg
Summary

This reduces the complexity of our already complex global lit configuration,
and also avoids cluttering the compilation commands for all tests with
things that are only relevant to the filesystem tests.

Diff Detail

Event Timeline

ldionne created this revision.Mar 25 2020, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2020, 10:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 252623.Mar 25 2020, 10:45 AM

Make sure we don't modify the cxx compiler flags globally

ldionne updated this revision to Diff 252644.Mar 25 2020, 12:00 PM

Don't set the dynamic test root, since that's not required if we're based on
the parent change. Apologies for the frantic updates, I have many outstanding
patches and my git got somewhat messed up.

EricWF accepted this revision.Mar 26 2020, 7:59 AM
This revision is now accepted and ready to land.Mar 26 2020, 7:59 AM
This revision was automatically updated to reflect the committed changes.