Page MenuHomePhabricator

[mlir] Clarify constraint on derived attribute
ClosedPublic

Authored by jpienaar on Mar 24 2020, 10:21 AM.

Details

Summary

The restriction that a derived attribute should represent an
attribute/be materializable as an attribute was not made clear.

Diff Detail

Event Timeline

jpienaar created this revision.Mar 24 2020, 10:21 AM
rriddle accepted this revision.Mar 24 2020, 11:42 AM
rriddle added inline comments.
mlir/docs/OpDefinitions.md
183

Why is this indented?

mlir/include/mlir/IR/OpBase.td
1390

typo: used

This revision is now accepted and ready to land.Mar 24 2020, 11:42 AM
jpienaar updated this revision to Diff 252414.Mar 24 2020, 12:59 PM
jpienaar marked 3 inline comments as done.

Fix typo

mlir/docs/OpDefinitions.md
183

It is a second paragraph under the numbered list item.

This revision was automatically updated to reflect the committed changes.