Page MenuHomePhabricator

[libc++] Bump Clang support for Clang 4
ClosedPublic

Authored by ldionne on Mar 23 2020, 8:41 AM.

Details

Reviewers
EricWF
Group Reviewers
Restricted Project
Commits
rG3c84aca9b357: [libc++] Bump Clang support for Clang 4
Summary

It's hard to imagine someone using a recent version of libc++ with a
roughly 3 years old Clang. Since we're not testing libc++ with Clang 3.5
anyway, claiming support for it is somewhat of a lie.

Note that we don't test Clang 4 either, however I have no reason to bump
the requirement beyond Clang 4 at the moment, whereas removing Clang 3.5
allows simplifying the test suite.

Diff Detail

Event Timeline

ldionne created this revision.Mar 23 2020, 8:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2020, 8:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
EricWF accepted this revision.Mar 23 2020, 8:58 AM
EricWF added a subscriber: EricWF.

LGTM.

I would like us to be even more aggressive bumping our compiler support,
but that's a conversation for another time.

This revision is now accepted and ready to land.Mar 23 2020, 8:58 AM

LGTM.

I would like us to be even more aggressive bumping our compiler support,
but that's a conversation for another time.

Me too, since I think the benefit users are getting for us supporting old compilers is probably much smaller than we think. Few people upgrade their stdlib without upgrading their compiler. Let's take it one step at a time for now.

This revision was automatically updated to reflect the committed changes.