Page MenuHomePhabricator

[MLIR] IfOP - Add a builder with result operands
ClosedPublic

Authored by nmostafa on Mar 20 2020, 1:46 PM.

Details

Summary

Add a new builder to IfOp to allow operation to define values.

Diff Detail

Event Timeline

nmostafa created this revision.Mar 20 2020, 1:46 PM
rriddle accepted this revision.Mar 20 2020, 2:17 PM
rriddle added inline comments.
mlir/include/mlir/Dialect/LoopOps/LoopOps.td
226

nit: Can you use TypeRange here instead of ArrayRef?

mlir/lib/Dialect/LoopOps/LoopOps.cpp
204

nit: Can you add a /*...=*/ comment to the llvm::None?

This revision is now accepted and ready to land.Mar 20 2020, 2:17 PM
nmostafa updated this revision to Diff 251793.Mar 20 2020, 4:08 PM

Review fixes.

nmostafa marked 2 inline comments as done.Mar 20 2020, 4:08 PM

Thanks, @rriddle . Will submit it soon.

lebedev.ri retitled this revision from IfOP - Add a builder with result operands to [MLIR] IfOP - Add a builder with result operands.Mar 20 2020, 4:18 PM
This revision was automatically updated to reflect the committed changes.