Page MenuHomePhabricator

nmostafa (Nagy Mostafa)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2020, 1:48 PM (12 w, 2 d)

Recent Activity

Mon, Mar 23

nmostafa accepted D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

LGTM. Thanks for fixing this !

Mon, Mar 23, 3:16 PM · Restricted Project
nmostafa added inline comments to D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..
Mon, Mar 23, 2:11 PM · Restricted Project

Fri, Mar 20

nmostafa committed rG141e5890d812: [MLIR] Add an IfOp builder with results (authored by nmostafa).
[MLIR] Add an IfOp builder with results
Fri, Mar 20, 5:23 PM
nmostafa closed D76524: [MLIR] IfOP - Add a builder with result operands.
Fri, Mar 20, 5:23 PM · Restricted Project
nmostafa added a comment to D76524: [MLIR] IfOP - Add a builder with result operands.

Thanks, @rriddle . Will submit it soon.

Fri, Mar 20, 4:18 PM · Restricted Project
nmostafa updated the diff for D76524: [MLIR] IfOP - Add a builder with result operands.

Review fixes.

Fri, Mar 20, 4:18 PM · Restricted Project
nmostafa created D76524: [MLIR] IfOP - Add a builder with result operands.
Fri, Mar 20, 2:07 PM · Restricted Project
nmostafa added a reviewer for D76524: [MLIR] IfOP - Add a builder with result operands: rriddle.
Fri, Mar 20, 2:07 PM · Restricted Project

Feb 27 2020

nmostafa added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

@herhut @flaub @silvas @nmostafa - I'd like to get your stand here as well. Please see the comment right above for the latest.

Feb 27 2020, 4:29 PM · Restricted Project

Feb 24 2020

nmostafa committed rG28e869578508: [MLIR] NFC - Fix indentation in examples in LoopOps.td (authored by nmostafa).
[MLIR] NFC - Fix indentation in examples in LoopOps.td
Feb 24 2020, 12:29 PM

Feb 21 2020

nmostafa set the repository for D74978: [MLIR] Remove constexpr from LoopOps.td to rG LLVM Github Monorepo.
Feb 21 2020, 11:45 AM · Restricted Project
nmostafa added a comment to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Fixed here: https://reviews.llvm.org/D74978

Feb 21 2020, 11:45 AM · Restricted Project
nmostafa created D74978: [MLIR] Remove constexpr from LoopOps.td.
Feb 21 2020, 11:45 AM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Fix LIT tests after merge from master.

Feb 21 2020, 9:55 AM · Restricted Project
nmostafa added a comment to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

If there are no further comments, going to commit this today.

Feb 21 2020, 9:00 AM · Restricted Project

Feb 18 2020

nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Add missing {} around else

Feb 18 2020, 11:40 AM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Rebased.
Use mlir::interleaveComma and remove assertion.

Feb 18 2020, 11:39 AM · Restricted Project

Feb 11 2020

nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
  • Remove types from iter_args assignment list.
  • Fix other nits per review.
Feb 11 2020, 5:49 PM · Restricted Project
nmostafa added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 11 2020, 3:35 PM · Restricted Project
nmostafa added a comment to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

How difficult is it to support both the old-style "does not return a value" and the new terminator that does return a value?

Feb 11 2020, 11:56 AM · Restricted Project

Feb 10 2020

nmostafa added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 10 2020, 1:13 PM · Restricted Project
nmostafa added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 10 2020, 1:13 PM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
  • Added custom printer for YieldOp
  • Added tests to verify loop.parallel yield has no operands. Negative test for that as well.
  • Updated td description for loop.parallel: yield without opreands
  • Updates to commit message
Feb 10 2020, 1:04 PM · Restricted Project

Feb 7 2020

nmostafa added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 7 2020, 4:05 PM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 7 2020, 3:56 PM · Restricted Project
nmostafa added inline comments to D74211: [mlir] use unpacked memref descriptors at function boundaries.
Feb 7 2020, 11:30 AM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Fix comments and documentation per review feedback.

Feb 7 2020, 9:31 AM · Restricted Project

Feb 6 2020

nmostafa added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 6 2020, 5:35 PM · Restricted Project
nmostafa updated the diff for D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .

Review fixes

Feb 6 2020, 5:29 PM · Restricted Project
nmostafa created D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Feb 6 2020, 3:02 PM · Restricted Project

Jan 17 2020

nmostafa added inline comments to D72935: [mlir] Add a canonicalization pattern for MemRefCastOp into dynamic MemRefs.
Jan 17 2020, 10:13 AM · Restricted Project