Page MenuHomePhabricator
Differential D76475

[X86][MC] Disable Prefix padding after hardcode/prefix
ClosedPublic
Actions

Authored by skan on Mar 19 2020, 8:11 PM.

Details

Reviewers
reames
MaskRay
craig.topper
LuoYuanke
jyknight
eli.friedman
Commits
rGd0efd7bfcf68: [X86][MC] Disable Prefix padding after hardcode/prefix

Diff Detail

Event Timeline

skan created this revision.Mar 19 2020, 8:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2020, 8:11 PM
skan mentioned this in D76286: [X86][MC] Support enhanced relaxation for branch align.Mar 19 2020, 8:20 PM
skan added a child revision: D76286: [X86][MC] Support enhanced relaxation for branch align.Mar 19 2020, 8:21 PM
skan mentioned this in D76176: [X86] Disable nop padding before instruction following hardcode.Mar 19 2020, 8:50 PM
Harbormaster completed remote builds in B49828: Diff 251541.Mar 19 2020, 8:53 PM
skan added a reviewer: eli.friedman.Mar 26 2020, 1:23 AM
skan updated this revision to Diff 253048.Mar 27 2020, 12:06 AM

Rebase

Harbormaster completed remote builds in B50660: Diff 253048.Mar 27 2020, 1:01 AM
craig.topper added inline comments.Mar 28 2020, 1:47 PM
llvm/test/MC/X86/align-via-padding-corner.s
6

There is an 'a' before and after the line break so this says "on a a instruction"

skan updated this revision to Diff 253509.Mar 30 2020, 12:34 AM

Address review comments

skan marked an inline comment as done.Mar 30 2020, 12:35 AM
Harbormaster completed remote builds in B50915: Diff 253509.Mar 30 2020, 1:35 AM
craig.topper accepted this revision.Mar 30 2020, 1:33 PM

LGTM

This revision is now accepted and ready to land.Mar 30 2020, 1:33 PM
Closed by commit rGd0efd7bfcf68: [X86][MC] Disable Prefix padding after hardcode/prefix (authored by skan). · Explain WhyMar 31 2020, 7:18 PM
This revision was automatically updated to reflect the committed changes.
skan removed a child revision: D76286: [X86][MC] Support enhanced relaxation for branch align.Apr 8 2020, 1:55 AM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
MC/
5 lines
lib/
Target/
X86/
MCTargetDesc/
65 lines
test/
MC/
X86/
29 lines

Diff 253509

View Options

llvm/include/llvm/MC/MCFragment.h

Loading...
View Options

llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp

Loading...
View Options

llvm/test/MC/X86/align-via-padding-corner.s

Loading...