Page MenuHomePhabricator

[ADT] CoalescingBitVector: Avoid initial heap allocation, NFC
ClosedPublic

Authored by vsk on Mar 19 2020, 4:54 PM.

Details

Summary

Avoid making a heap allocation when constructing a CoalescingBitVector.

This reduces time spent in LiveDebugValues when compiling sqlite3 by
700ms (0.5% of the total User Time).

rdar://60046261

Diff Detail

Event Timeline

vsk created this revision.Mar 19 2020, 4:54 PM
aprantl accepted this revision.Mar 20 2020, 8:47 AM

Should we then call it SmallCoalescingBitVector? Probably not :-)

This revision is now accepted and ready to land.Mar 20 2020, 8:47 AM
jmorse accepted this revision.Mar 20 2020, 10:15 AM

LGTM

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2020, 12:29 PM