Diff Detail
Event Timeline
llvm/lib/CodeGen/MachinePipeliner.cpp | ||
---|---|---|
317 | it looks like more appropriate place to set to default state would be in start of setPragmaPipelineOptions: void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) { disabledByPragma = false; Additionally, II_setByPragma could also be set to default state here. though this is for separate patch. |
llvm/lib/CodeGen/MachinePipeliner.cpp | ||
---|---|---|
295 | now it becomes depending on order of metadata. It works for "distinct !{!8, !7, !9}" and does not work for distinct !{!8, !9, !7} . This default value should be set in the first line of setPragmaPipelineOptions (before other instructions): void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) { disabledByPragma = false; |
llvm/lib/CodeGen/MachinePipeliner.cpp | ||
---|---|---|
295 | I did not realize this is inside the loop. I will move this before we start executing this loop. |
this lgtm for me, with nit in comments. Also, please wait some time for others opinions.
llvm/lib/CodeGen/MachinePipeliner.cpp | ||
---|---|---|
293 | please delete this extra line. |
Already integrated by this commit - https://reviews.llvm.org/rGa04ab2ec08014d36337d686d43ecef7668622f1b
please delete this extra line.