♟ sgundapa

Thanks for the patch David.
I do see this patch generating post-incs in at-least one of the tests I have.

[Pipeliner] Fix the bug in pragma that disables the pipeliner.

Update LSR's logic that identifies a post-increment SCEV value.

Thanks for reviewing this patch. I have merged the change.

Update LSR's logic that identifies a post-increment SCEV value.

I forgot to update the Differential Revision in the commit.

[Pipeliner] Fix an assertion caused by iterator invalidation.

[Hexagon] Validate the iterators before converting them to mux.

Update lit infra to detect "MemoryWithOrigins' sanitizer build.

[Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.

Thanks for fixing the unit test.

[Pipeliner] Ignore Artificial dependences while computing recurrences.

[Pipeliner] Remove the unneeded include header(NFC).

You are correct. I have pushed https://reviews.llvm.org/D53451 to rectify.

[Pipeliner] copyToPhi DAG Mutation to improve scheduling.

[Hexagon] Restrict compound instructions with constant value.

[Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC)

[Pipeliner] Fix the Schedule DAG topoligical order.

I was not able to formulate a unit test that exposes this issue.
I figured this problem when I was working on a DAG mutation for the pipeliner.

There is no test case associated with this patch as I have not found one yet.

Thanks for taking care of this

This patch is already merged in a different commit

[Hexagon] Handling of new HVX flags and target-features

[Hexagon] New HVX target features.

[Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC)

[Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC)

This patch is committed in r309445

Add documentation for the attribute "no-jump-tables"

[SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup…

Hans, I am not sure if this is the correct place and correct way to add the documentation. Let me know

Also it makes me sad that the attribute isn't documented anywhere. Would you like to look into that, possible as a follow-up patch?

Sure. I will push a follow up patch

We have decided to have this feature under "-fno-jump-tables" clang flag.
To this affect, this patch updates the code to control the generation of
lookup tables based on the attribute "no-jump-tables"

The only change that is needed is to disable lookup-tables based on the attribute "no-jump-tables" set by "-fno-jump-tables" clang flag.
It implies that this change is not required.

Refer to https://reviews.llvm.org/D35577 as we decided to disable lookup tables under -fno-jump-tables

Thanks. I will make change to this affect

I am waiting for others to approve/review the decision.

If it is okay for the reviewers, I have no problem using -fno-jump-tables to this effect.
I need to update https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579

"Should this just be part of the tuning for the hexagon backend and not options at all"

This will be useful to all the backends/archs that support a tightly coupled memory.
AFAIK, hexagon is not the only target that has a TCM.

This is not going to be a temporary option

sgundapa (Sumanth Gundapaneni)
User

Projects

User Details

Recent Activity
View All

May 20 2020

May 5 2020

Apr 10 2020

Mar 18 2020

Mar 17 2020

Mar 2 2020

Feb 27 2020

Feb 24 2020

Nov 14 2019

Oct 3 2019

Nov 7 2018

Oct 29 2018

Oct 25 2018

Oct 22 2018

Oct 19 2018

Oct 18 2018

Oct 15 2018

Oct 11 2018

Oct 10 2018

Jan 29 2018

Oct 18 2017

Oct 17 2017

Oct 12 2017

Oct 4 2017

Jul 31 2017

Jul 28 2017

Jul 27 2017

Jul 26 2017

Jul 24 2017

Jul 21 2017

sgundapa (Sumanth Gundapaneni)User