Page MenuHomePhabricator

sgundapa (Sumanth Gundapaneni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2014, 10:06 AM (337 w, 3 d)

Recent Activity

May 20 2020

sgundapa accepted D80273: [LSR] Filter for postinc formulae.

Thanks for the patch David.
I do see this patch generating post-incs in at-least one of the tests I have.

May 20 2020, 2:53 PM · Restricted Project

May 5 2020

sgundapa accepted D79301: [LSR] Don't require reuse register under postinc.
May 5 2020, 8:03 AM · Restricted Project

Apr 10 2020

sgundapa committed rGa04ab2ec0801: [Pipeliner] Fix the bug in pragma that disables the pipeliner. (authored by sgundapa).
[Pipeliner] Fix the bug in pragma that disables the pipeliner.
Apr 10 2020, 10:53 AM

Mar 18 2020

sgundapa set the repository for D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner to rG LLVM Github Monorepo.
Mar 18 2020, 9:14 AM · Restricted Project
sgundapa updated the diff for D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner.
Mar 18 2020, 8:41 AM · Restricted Project
sgundapa added inline comments to D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner.
Mar 18 2020, 8:41 AM · Restricted Project
sgundapa updated the diff for D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner.
Mar 18 2020, 7:36 AM · Restricted Project

Mar 17 2020

sgundapa created D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner.
Mar 17 2020, 11:16 AM · Restricted Project
sgundapa set the repository for D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner to rG LLVM Github Monorepo.
Mar 17 2020, 11:16 AM · Restricted Project

Mar 2 2020

sgundapa committed rG9897daa6bfcc: Update LSR's logic that identifies a post-increment SCEV value. (authored by sgundapa).
Update LSR's logic that identifies a post-increment SCEV value.
Mar 2 2020, 2:57 PM
sgundapa closed D75079: Update LSR's logic that identifies a post-increment SCEV value..
Mar 2 2020, 2:57 PM · Restricted Project
sgundapa added a comment to D75079: Update LSR's logic that identifies a post-increment SCEV value..

Thanks for reviewing this patch. I have merged the change.

Mar 2 2020, 12:32 PM · Restricted Project
sgundapa committed rG45bd202f900e: Update LSR's logic that identifies a post-increment SCEV value. (authored by sgundapa).
Update LSR's logic that identifies a post-increment SCEV value.
Mar 2 2020, 12:30 PM

Feb 27 2020

sgundapa added a reviewer for D75079: Update LSR's logic that identifies a post-increment SCEV value.: apazos.
Feb 27 2020, 8:45 AM · Restricted Project

Feb 24 2020

sgundapa created D75079: Update LSR's logic that identifies a post-increment SCEV value..
Feb 24 2020, 2:20 PM · Restricted Project

Nov 14 2019

sgundapa closed D68405: [Pipeliner] Fix an assertion caused by iterator invalidation..

I forgot to update the Differential Revision in the commit.

Nov 14 2019, 11:20 AM · Restricted Project
sgundapa closed D68401: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly..

I forgot to update the Differential Revision in the commit.

Nov 14 2019, 11:20 AM · Restricted Project
sgundapa closed D68402: [Hexagon] Validate the iterators before converting them to mux..

I forgot to update the Differential Revision in the commit.

Nov 14 2019, 11:20 AM · Restricted Project
sgundapa committed rG7c7e368a7ffc: [Pipeliner] Fix an assertion caused by iterator invalidation. (authored by sgundapa).
[Pipeliner] Fix an assertion caused by iterator invalidation.
Nov 14 2019, 11:12 AM
sgundapa committed rGfdf1ae37cfa8: [Hexagon] Validate the iterators before converting them to mux. (authored by sgundapa).
[Hexagon] Validate the iterators before converting them to mux.
Nov 14 2019, 11:02 AM
sgundapa committed rGe85a96ddbfb4: Update lit infra to detect "MemoryWithOrigins' sanitizer build. (authored by sgundapa).
Update lit infra to detect "MemoryWithOrigins' sanitizer build.
Nov 14 2019, 11:02 AM
sgundapa committed rG9fcf4f372c7e: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly. (authored by sgundapa).
[Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.
Nov 14 2019, 11:02 AM
sgundapa closed D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Nov 14 2019, 11:02 AM · Restricted Project

Oct 3 2019

sgundapa created D68405: [Pipeliner] Fix an assertion caused by iterator invalidation..
Oct 3 2019, 9:37 AM · Restricted Project
sgundapa abandoned D68404: [Pipeliner] Fix an assertion caused by iterator invalidation..
Oct 3 2019, 9:32 AM · Restricted Project
sgundapa created D68404: [Pipeliner] Fix an assertion caused by iterator invalidation..
Oct 3 2019, 9:32 AM · Restricted Project
sgundapa created D68402: [Hexagon] Validate the iterators before converting them to mux..
Oct 3 2019, 9:20 AM · Restricted Project
sgundapa created D68401: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly..
Oct 3 2019, 8:52 AM · Restricted Project
sgundapa created D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Oct 3 2019, 8:32 AM · Restricted Project
sgundapa committed rG069cb6282db8: Test commit. (authored by sgundapa).
Test commit.
Oct 3 2019, 7:58 AM
sgundapa committed rL373609: Test commit..
Test commit.
Oct 3 2019, 7:56 AM

Nov 7 2018

sgundapa accepted D54210: [Hexagon] Implement noreturn optimization.
Nov 7 2018, 8:25 AM

Oct 29 2018

sgundapa added a comment to D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..

Thanks for fixing the unit test.

Oct 29 2018, 7:21 PM

Oct 25 2018

sgundapa committed rL345319: [Pipeliner] Ignore Artificial dependences while computing recurrences..
[Pipeliner] Ignore Artificial dependences while computing recurrences.
Oct 25 2018, 2:30 PM
sgundapa closed D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..
Oct 25 2018, 2:30 PM
sgundapa committed rL345318: [Pipeliner] Remove the unneeded include header(NFC)..
[Pipeliner] Remove the unneeded include header(NFC).
Oct 25 2018, 2:27 PM
sgundapa closed D53451: [Pipeliner] Remove the unneeded include header..
Oct 25 2018, 2:27 PM

Oct 22 2018

sgundapa accepted D53477: Split MachinePipeliner code into header and cpp files.

Looks good to me.

Oct 22 2018, 3:55 PM

Oct 19 2018

sgundapa added a comment to D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..

You are correct. I have pushed https://reviews.llvm.org/D53451 to rectify.

Oct 19 2018, 1:23 PM
sgundapa created D53451: [Pipeliner] Remove the unneeded include header..
Oct 19 2018, 1:22 PM
sgundapa created D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..
Oct 19 2018, 1:15 PM

Oct 18 2018

sgundapa committed rL344748: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
[Pipeliner] copyToPhi DAG Mutation to improve scheduling.
Oct 18 2018, 8:53 AM
sgundapa closed D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 18 2018, 8:53 AM
sgundapa added inline comments to D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 18 2018, 8:49 AM

Oct 15 2018

sgundapa updated the diff for D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 15 2018, 3:53 PM
sgundapa created D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 15 2018, 3:50 PM

Oct 11 2018

sgundapa committed rL344284: [Hexagon] Restrict compound instructions with constant value..
[Hexagon] Restrict compound instructions with constant value.
Oct 11 2018, 12:50 PM
sgundapa closed D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:50 PM
sgundapa committed rL344283: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
[Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC)
Oct 11 2018, 12:48 PM
sgundapa closed D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
Oct 11 2018, 12:48 PM
sgundapa committed rL344282: [Pipeliner] Fix the Schedule DAG topoligical order..
[Pipeliner] Fix the Schedule DAG topoligical order.
Oct 11 2018, 12:44 PM
sgundapa closed D53105: [Pipeliner] Fix the Schedule DAG topoligical order..
Oct 11 2018, 12:44 PM
sgundapa updated the diff for D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:34 PM
sgundapa added inline comments to D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:32 PM
sgundapa created D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 11:11 AM

Oct 10 2018

sgundapa added a comment to D53105: [Pipeliner] Fix the Schedule DAG topoligical order..

I was not able to formulate a unit test that exposes this issue.
I figured this problem when I was working on a DAG mutation for the pipeliner.

Oct 10 2018, 12:44 PM
sgundapa created D53105: [Pipeliner] Fix the Schedule DAG topoligical order..
Oct 10 2018, 12:43 PM
sgundapa added a comment to D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).

There is no test case associated with this patch as I have not found one yet.

Oct 10 2018, 12:06 PM
sgundapa created D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
Oct 10 2018, 12:06 PM

Jan 29 2018

sgundapa added a comment to D41757: Add a config note and fix a config variable regarding CCACHE support..

Thanks for taking care of this

Jan 29 2018, 1:27 PM

Oct 18 2017

sgundapa abandoned D39071: [Hexagon] Fix the memory-leak in r316102 .

This patch is already merged in a different commit

Oct 18 2017, 6:39 PM
sgundapa created D39071: [Hexagon] Fix the memory-leak in r316102 .
Oct 18 2017, 2:43 PM
sgundapa added a reviewer for D39071: [Hexagon] Fix the memory-leak in r316102 : Vlad.
Oct 18 2017, 2:43 PM
sgundapa removed a reviewer for D39071: [Hexagon] Fix the memory-leak in r316102 : Vlad.
Oct 18 2017, 2:43 PM
sgundapa committed rL316102: [Hexagon] Handling of new HVX flags and target-features.
[Hexagon] Handling of new HVX flags and target-features
Oct 18 2017, 11:10 AM
sgundapa closed D38852: [Hexagon] Handling of new HVX flags and target-features by committing rL316102: [Hexagon] Handling of new HVX flags and target-features.
Oct 18 2017, 11:10 AM
sgundapa committed rL316101: [Hexagon] New HVX target features..
[Hexagon] New HVX target features.
Oct 18 2017, 11:08 AM
sgundapa closed D38851: [Hexagon] New HVX target features. by committing rL316101: [Hexagon] New HVX target features..
Oct 18 2017, 11:07 AM
sgundapa committed rL316099: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
[Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC)
Oct 18 2017, 10:45 AM
sgundapa closed D38850: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC) by committing rL316099: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
Oct 18 2017, 10:45 AM
sgundapa added a comment to D38852: [Hexagon] Handling of new HVX flags and target-features.

Ping

Oct 18 2017, 8:03 AM

Oct 17 2017

sgundapa added a reviewer for D38852: [Hexagon] Handling of new HVX flags and target-features: dlj.
Oct 17 2017, 2:08 PM

Oct 12 2017

sgundapa updated the summary of D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:31 AM
sgundapa updated the summary of D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:30 AM
sgundapa created D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:28 AM
sgundapa created D38851: [Hexagon] New HVX target features..
Oct 12 2017, 9:25 AM
sgundapa created D38850: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
Oct 12 2017, 9:22 AM

Oct 4 2017

sgundapa committed rL314926: [Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
[Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC)
Oct 4 2017, 12:11 PM
sgundapa closed D38548: Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC) by committing rL314926: [Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
Oct 4 2017, 12:11 PM
sgundapa created D38548: Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
Oct 4 2017, 9:47 AM

Jul 31 2017

sgundapa added a comment to rL309487: Fix test failure without X86 backend.

Thanks for this fix

Jul 31 2017, 8:34 AM

Jul 28 2017

sgundapa closed D35999: Add documentation for the attribute "no-jump-tables".

This patch is committed in r309445

Jul 28 2017, 3:30 PM
sgundapa committed rL309445: Add documentation for the attribute "no-jump-tables".
Add documentation for the attribute "no-jump-tables"
Jul 28 2017, 3:29 PM
sgundapa committed rL309444: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup….
[SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup…
Jul 28 2017, 3:26 PM
sgundapa closed D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables by committing rL309444: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup….
Jul 28 2017, 3:26 PM
sgundapa abandoned D33605: Provide an acccessor to get the Args of a ToolChain.
Jul 28 2017, 3:19 PM · Restricted Project
sgundapa abandoned D15389: Ensure ISL is always compiled with std=gnu99. NFC.
Jul 28 2017, 3:18 PM
sgundapa added a comment to D35999: Add documentation for the attribute "no-jump-tables".

Hans, I am not sure if this is the correct place and correct way to add the documentation. Let me know

Jul 28 2017, 7:31 AM
sgundapa created D35999: Add documentation for the attribute "no-jump-tables".
Jul 28 2017, 7:30 AM
sgundapa added a comment to D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

Also it makes me sad that the attribute isn't documented anywhere. Would you like to look into that, possible as a follow-up patch?

Sure. I will push a follow up patch

Jul 28 2017, 7:18 AM
sgundapa updated the diff for D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.
Jul 28 2017, 7:17 AM

Jul 27 2017

sgundapa updated the diff for D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

We have decided to have this feature under "-fno-jump-tables" clang flag.
To this affect, this patch updates the code to control the generation of
lookup tables based on the attribute "no-jump-tables"

Jul 27 2017, 12:50 PM
sgundapa abandoned D35577: Add -flookup-tables and -fno-lookup-tables flags.
Jul 27 2017, 12:27 PM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

The only change that is needed is to disable lookup-tables based on the attribute "no-jump-tables" set by "-fno-jump-tables" clang flag.
It implies that this change is not required.

Jul 27 2017, 12:27 PM
sgundapa abandoned D35578: Add -fswitch-tables and -fno-switch-tables flags.

Refer to https://reviews.llvm.org/D35577 as we decided to disable lookup tables under -fno-jump-tables

Jul 27 2017, 12:24 PM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

Thanks. I will make change to this affect

Jul 27 2017, 10:58 AM

Jul 26 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

I am waiting for others to approve/review the decision.

Jul 26 2017, 5:54 PM

Jul 24 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

If it is okay for the reviewers, I have no problem using -fno-jump-tables to this effect.
I need to update https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579

Jul 24 2017, 8:21 AM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

"Should this just be part of the tuning for the hexagon backend and not options at all"

This will be useful to all the backends/archs that support a tightly coupled memory.
AFAIK, hexagon is not the only target that has a TCM.

Jul 24 2017, 7:27 AM

Jul 21 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

This is not going to be a temporary option

Jul 21 2017, 1:18 PM