Page MenuHomePhabricator

sgundapa (Sumanth Gundapaneni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2014, 10:06 AM (279 w, 4 d)

Recent Activity

Thu, Oct 3

sgundapa created D68405: [Pipeliner] Fix an assertion caused by iterator invalidation..
Thu, Oct 3, 9:37 AM · Restricted Project
sgundapa abandoned D68404: [Pipeliner] Fix an assertion caused by iterator invalidation..
Thu, Oct 3, 9:32 AM · Restricted Project
sgundapa created D68404: [Pipeliner] Fix an assertion caused by iterator invalidation..
Thu, Oct 3, 9:32 AM · Restricted Project
sgundapa created D68402: [Hexagon] Validate the iterators before converting them to mux..
Thu, Oct 3, 9:20 AM · Restricted Project
sgundapa created D68401: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly..
Thu, Oct 3, 8:52 AM · Restricted Project
sgundapa created D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Thu, Oct 3, 8:32 AM · Restricted Project
sgundapa committed rG069cb6282db8: Test commit. (authored by sgundapa).
Test commit.
Thu, Oct 3, 7:58 AM
sgundapa committed rL373609: Test commit..
Test commit.
Thu, Oct 3, 7:56 AM

Nov 7 2018

sgundapa accepted D54210: [Hexagon] Implement noreturn optimization.
Nov 7 2018, 8:25 AM

Oct 29 2018

sgundapa added a comment to D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..

Thanks for fixing the unit test.

Oct 29 2018, 7:21 PM

Oct 25 2018

sgundapa committed rL345319: [Pipeliner] Ignore Artificial dependences while computing recurrences..
[Pipeliner] Ignore Artificial dependences while computing recurrences.
Oct 25 2018, 2:30 PM
sgundapa closed D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..
Oct 25 2018, 2:30 PM
sgundapa committed rL345318: [Pipeliner] Remove the unneeded include header(NFC)..
[Pipeliner] Remove the unneeded include header(NFC).
Oct 25 2018, 2:27 PM
sgundapa closed D53451: [Pipeliner] Remove the unneeded include header..
Oct 25 2018, 2:27 PM

Oct 22 2018

sgundapa accepted D53477: Split MachinePipeliner code into header and cpp files.

Looks good to me.

Oct 22 2018, 3:55 PM

Oct 19 2018

sgundapa added a comment to D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..

You are correct. I have pushed https://reviews.llvm.org/D53451 to rectify.

Oct 19 2018, 1:23 PM
sgundapa created D53451: [Pipeliner] Remove the unneeded include header..
Oct 19 2018, 1:22 PM
sgundapa created D53450: [Pipeliner] Ignore Artificial dependences while computing recurrences..
Oct 19 2018, 1:15 PM

Oct 18 2018

sgundapa committed rL344748: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
[Pipeliner] copyToPhi DAG Mutation to improve scheduling.
Oct 18 2018, 8:53 AM
sgundapa closed D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 18 2018, 8:53 AM
sgundapa added inline comments to D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 18 2018, 8:49 AM

Oct 15 2018

sgundapa updated the diff for D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 15 2018, 3:53 PM
sgundapa created D53303: [Pipeliner] copyToPhi DAG Mutation to improve scheduling..
Oct 15 2018, 3:50 PM

Oct 11 2018

sgundapa committed rL344284: [Hexagon] Restrict compound instructions with constant value..
[Hexagon] Restrict compound instructions with constant value.
Oct 11 2018, 12:50 PM
sgundapa closed D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:50 PM
sgundapa committed rL344283: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
[Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC)
Oct 11 2018, 12:48 PM
sgundapa closed D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
Oct 11 2018, 12:48 PM
sgundapa committed rL344282: [Pipeliner] Fix the Schedule DAG topoligical order..
[Pipeliner] Fix the Schedule DAG topoligical order.
Oct 11 2018, 12:44 PM
sgundapa closed D53105: [Pipeliner] Fix the Schedule DAG topoligical order..
Oct 11 2018, 12:44 PM
sgundapa updated the diff for D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:34 PM
sgundapa added inline comments to D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 12:32 PM
sgundapa created D53152: [Hexagon] Restrict compound instructions with constant value..
Oct 11 2018, 11:11 AM

Oct 10 2018

sgundapa added a comment to D53105: [Pipeliner] Fix the Schedule DAG topoligical order..

I was not able to formulate a unit test that exposes this issue.
I figured this problem when I was working on a DAG mutation for the pipeliner.

Oct 10 2018, 12:44 PM
sgundapa created D53105: [Pipeliner] Fix the Schedule DAG topoligical order..
Oct 10 2018, 12:43 PM
sgundapa added a comment to D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).

There is no test case associated with this patch as I have not found one yet.

Oct 10 2018, 12:06 PM
sgundapa created D53104: [Pipeliner] Use the Index from Topo instead of relying on NodeNum. (NFC).
Oct 10 2018, 12:06 PM

Jan 29 2018

sgundapa added a comment to D41757: Add a config note and fix a config variable regarding CCACHE support..

Thanks for taking care of this

Jan 29 2018, 1:27 PM

Oct 18 2017

sgundapa abandoned D39071: [Hexagon] Fix the memory-leak in r316102 .

This patch is already merged in a different commit

Oct 18 2017, 6:39 PM
sgundapa created D39071: [Hexagon] Fix the memory-leak in r316102 .
Oct 18 2017, 2:43 PM
sgundapa added a reviewer for D39071: [Hexagon] Fix the memory-leak in r316102 : Vlad.
Oct 18 2017, 2:43 PM
sgundapa removed a reviewer for D39071: [Hexagon] Fix the memory-leak in r316102 : Vlad.
Oct 18 2017, 2:43 PM
sgundapa committed rL316102: [Hexagon] Handling of new HVX flags and target-features.
[Hexagon] Handling of new HVX flags and target-features
Oct 18 2017, 11:10 AM
sgundapa closed D38852: [Hexagon] Handling of new HVX flags and target-features by committing rL316102: [Hexagon] Handling of new HVX flags and target-features.
Oct 18 2017, 11:10 AM
sgundapa committed rL316101: [Hexagon] New HVX target features..
[Hexagon] New HVX target features.
Oct 18 2017, 11:08 AM
sgundapa closed D38851: [Hexagon] New HVX target features. by committing rL316101: [Hexagon] New HVX target features..
Oct 18 2017, 11:07 AM
sgundapa committed rL316099: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
[Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC)
Oct 18 2017, 10:45 AM
sgundapa closed D38850: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC) by committing rL316099: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
Oct 18 2017, 10:45 AM
sgundapa added a comment to D38852: [Hexagon] Handling of new HVX flags and target-features.

Ping

Oct 18 2017, 8:03 AM

Oct 17 2017

sgundapa added a reviewer for D38852: [Hexagon] Handling of new HVX flags and target-features: dlj.
Oct 17 2017, 2:08 PM

Oct 12 2017

sgundapa updated the summary of D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:31 AM
sgundapa updated the summary of D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:30 AM
sgundapa created D38852: [Hexagon] Handling of new HVX flags and target-features.
Oct 12 2017, 9:28 AM
sgundapa created D38851: [Hexagon] New HVX target features..
Oct 12 2017, 9:25 AM
sgundapa created D38850: [Hexagon] Update Hexagon ArchEnum and sync some downstream changes(NFC).
Oct 12 2017, 9:22 AM

Oct 4 2017

sgundapa committed rL314926: [Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
[Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC)
Oct 4 2017, 12:11 PM
sgundapa closed D38548: Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC) by committing rL314926: [Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
Oct 4 2017, 12:11 PM
sgundapa created D38548: Hexagon] Move getHexagonTargetFeatures to Hexagon.cpp (NFC).
Oct 4 2017, 9:47 AM

Jul 31 2017

sgundapa added a comment to rL309487: Fix test failure without X86 backend.

Thanks for this fix

Jul 31 2017, 8:34 AM

Jul 28 2017

sgundapa closed D35999: Add documentation for the attribute "no-jump-tables".

This patch is committed in r309445

Jul 28 2017, 3:30 PM
sgundapa committed rL309445: Add documentation for the attribute "no-jump-tables".
Add documentation for the attribute "no-jump-tables"
Jul 28 2017, 3:29 PM
sgundapa committed rL309444: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup….
[SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup…
Jul 28 2017, 3:26 PM
sgundapa closed D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables by committing rL309444: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup….
Jul 28 2017, 3:26 PM
sgundapa abandoned D33605: Provide an acccessor to get the Args of a ToolChain.
Jul 28 2017, 3:19 PM · Restricted Project
sgundapa abandoned D15389: Ensure ISL is always compiled with std=gnu99. NFC.
Jul 28 2017, 3:18 PM
sgundapa added a comment to D35999: Add documentation for the attribute "no-jump-tables".

Hans, I am not sure if this is the correct place and correct way to add the documentation. Let me know

Jul 28 2017, 7:31 AM
sgundapa created D35999: Add documentation for the attribute "no-jump-tables".
Jul 28 2017, 7:30 AM
sgundapa added a comment to D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

Also it makes me sad that the attribute isn't documented anywhere. Would you like to look into that, possible as a follow-up patch?

Sure. I will push a follow up patch

Jul 28 2017, 7:18 AM
sgundapa updated the diff for D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.
Jul 28 2017, 7:17 AM

Jul 27 2017

sgundapa updated the diff for D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

We have decided to have this feature under "-fno-jump-tables" clang flag.
To this affect, this patch updates the code to control the generation of
lookup tables based on the attribute "no-jump-tables"

Jul 27 2017, 12:50 PM
sgundapa abandoned D35577: Add -flookup-tables and -fno-lookup-tables flags.
Jul 27 2017, 12:27 PM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

The only change that is needed is to disable lookup-tables based on the attribute "no-jump-tables" set by "-fno-jump-tables" clang flag.
It implies that this change is not required.

Jul 27 2017, 12:27 PM
sgundapa abandoned D35578: Add -fswitch-tables and -fno-switch-tables flags.

Refer to https://reviews.llvm.org/D35577 as we decided to disable lookup tables under -fno-jump-tables

Jul 27 2017, 12:24 PM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

Thanks. I will make change to this affect

Jul 27 2017, 10:58 AM

Jul 26 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

I am waiting for others to approve/review the decision.

Jul 26 2017, 5:54 PM

Jul 24 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

If it is okay for the reviewers, I have no problem using -fno-jump-tables to this effect.
I need to update https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579

Jul 24 2017, 8:21 AM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

"Should this just be part of the tuning for the hexagon backend and not options at all"

This will be useful to all the backends/archs that support a tightly coupled memory.
AFAIK, hexagon is not the only target that has a TCM.

Jul 24 2017, 7:27 AM

Jul 21 2017

sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

This is not going to be a temporary option

Jul 21 2017, 1:18 PM
sgundapa added a comment to D35577: Add -flookup-tables and -fno-lookup-tables flags.

The discussion is scattered across these patches https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579.
I will provide a brief summary here:

Jul 21 2017, 7:45 AM

Jul 19 2017

sgundapa added a comment to D35578: Add -fswitch-tables and -fno-switch-tables flags.

Moreover, why can't this determining factor be built into the compiler so the user doesn't even have to bother. That would be a more ideal user experience.

Here is a use case : For the code that stays in TCM, the customer doesn't want the data that the code refers to be outside of TCM. As kparzysz mentioned, the loads cause a huge latency and is not intended. Disabling table generation is the right thing to do here. For code that stays in regular memory, generating tables is far more efficient than a bunch of if-elses.

Jul 19 2017, 3:50 PM
sgundapa added a comment to D35578: Add -fswitch-tables and -fno-switch-tables flags.

Wouldn't the fix be to make the backend deal with this, then? Either by putting the table with the function text, or or opting out of lookup tables? It seems that might be a better experience for the user.

That is perfectly reasonable and in fact i have committed a hexagon change recently to that effect . The llvm flag hexagon-emi-lookup-tables controls the generation of lookup table for hexagon.
The problem is, I don't want the users of the compiler to use a combination of front end and back end flags to get the desired result.
"-fno-jump-tables -mllvm -hexagon-emit-lookup-tables=false". This could be much neater with a "-fno-jump-tables -fno-lookup-tables" or better just "-fno-switch-tables"

Jul 19 2017, 10:09 AM
sgundapa added a comment to D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

It looks like TargetTransformInfo already has a hook, shouldBuildLookupTables(), for disabling this optimization. Why not just set that to false for Hexagon?

TCM is often small and you don't want to either enable or disable the table generation for a specific backend. As of today,
hexagon-emit-lookup-tables llvm flag control the generation of lookup tables for hexagon backend.
The real problem here is , I do not want the user to use a combination of front end and backend flags to get the desired result.

Jul 19 2017, 10:09 AM
sgundapa added inline comments to D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.
Jul 19 2017, 9:44 AM
sgundapa updated the diff for D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

Made changes as per reviewers comments

Jul 19 2017, 9:41 AM
sgundapa updated the diff for D35577: Add -flookup-tables and -fno-lookup-tables flags.

Made the changes asked by reviewers

Jul 19 2017, 9:00 AM
sgundapa added a comment to D35578: Add -fswitch-tables and -fno-switch-tables flags.

I will try to address the concerns here:

Jul 19 2017, 8:37 AM
sgundapa added a comment to D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.

For backends with "tightly coupled memory", in scenarios where the data is far away from text pays a good amount of penalty in terms of latency.
Hexagon is one such backend. The tables (both lookup and jump) which are being generated are treated as globals with internal linkage and by default
will be placed in read only data.

Jul 19 2017, 8:21 AM

Jul 18 2017

sgundapa added a comment to D35578: Add -fswitch-tables and -fno-switch-tables flags.

The switch-case statements generate two kinds of tables.

  1. Jump tables
  2. Lookup tables.
Jul 18 2017, 2:01 PM
sgundapa updated subscribers of D35578: Add -fswitch-tables and -fno-switch-tables flags.
Jul 18 2017, 1:37 PM
sgundapa updated subscribers of D35577: Add -flookup-tables and -fno-lookup-tables flags.
Jul 18 2017, 1:36 PM
sgundapa updated subscribers of D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.
Jul 18 2017, 1:36 PM
sgundapa created D35579: [SimplifyCFG] Make the no-jump-tables attribute also disable switch lookup tables.
Jul 18 2017, 1:35 PM
sgundapa added a comment to D35578: Add -fswitch-tables and -fno-switch-tables flags.

This patch relies on https://reviews.llvm.org/D35577

Jul 18 2017, 1:15 PM
sgundapa updated subscribers of D35577: Add -flookup-tables and -fno-lookup-tables flags.
Jul 18 2017, 1:15 PM
sgundapa created D35578: Add -fswitch-tables and -fno-switch-tables flags.
Jul 18 2017, 1:15 PM
sgundapa added a reviewer for D35577: Add -flookup-tables and -fno-lookup-tables flags: kparzysz.
Jul 18 2017, 1:01 PM
sgundapa created D35577: Add -flookup-tables and -fno-lookup-tables flags.
Jul 18 2017, 12:56 PM
sgundapa committed rL308316: [Hexagon] Emit lookup tables in text section based on a flag.
[Hexagon] Emit lookup tables in text section based on a flag
Jul 18 2017, 8:32 AM
sgundapa closed D34818: [Hexagon] Emit lookup tables in text section based on a flag by committing rL308316: [Hexagon] Emit lookup tables in text section based on a flag.
Jul 18 2017, 8:32 AM

Jun 30 2017

sgundapa committed rL306877: [Hexagon] Guard the generation of lookup table.
[Hexagon] Guard the generation of lookup table
Jun 30 2017, 1:54 PM
sgundapa closed D34819: [Hexagon] Guard the generation of lookup table by committing rL306877: [Hexagon] Guard the generation of lookup table.
Jun 30 2017, 1:54 PM