Page MenuHomePhabricator

[clang][AArch64] readd support for 'p' inline asm constraint
ClosedPublic

Authored by nickdesaulniers on Mar 17 2020, 9:59 AM.

Details

Summary

Was accidentally removed by commit af64948e2a05 when it overrode
TargetInfo::convertConstraint.

Fixes: pr/45225

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 9:59 AM
nickdesaulniers marked an inline comment as done.Mar 17 2020, 10:00 AM
nickdesaulniers added inline comments.
clang/lib/Basic/Targets/AArch64.h
101

bah, need to return R for the previous case.

sdesmalen accepted this revision.Mar 17 2020, 10:04 AM
sdesmalen added a subscriber: sdesmalen.

LGTM!

clang/lib/Basic/Targets/AArch64.h
97–100

nit: does this need a default: break?

This revision is now accepted and ready to land.Mar 17 2020, 10:04 AM
nickdesaulniers marked an inline comment as done.Mar 17 2020, 10:06 AM

@sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing with the previous version being reviewed and not the current one.

clang/test/CodeGen/inline-asm-p-constraint.c
2

Does this need REQUIRES: aarch64-registered-target?

echristo added inline comments.
clang/test/CodeGen/inline-asm-p-constraint.c
2

It shouldn't unless it's calling into the backend somewhere.

sdesmalen accepted this revision.Mar 17 2020, 10:47 AM

@sdesmalen sorry, would you mind re-reviewing. I'm not comfortable landing with the previous version being reviewed and not the current one.

Sure, thanks for checking! LGTM!

This revision was automatically updated to reflect the committed changes.