This is an archive of the discontinued LLVM Phabricator instance.

Enforce that libc++ and libc++abi are built in a monorepo layout
ClosedPublic

Authored by ldionne on Mar 12 2020, 3:05 PM.

Details

Reviewers
EricWF
phosek
ldionne
Group Reviewers
Restricted Project
Restricted Project
Commits
rG19aec8c90492: Enforce that libc++ and libc++abi are built in a monorepo layout
Summary

We will soon start removing technical debt and sharing code between the
two directories, so this first step is meant to discover potential places
where the libraries are built outside of a monorepo layout. I imagine
this could happen as a remnant of the pre-monorepo setup.

This was discussed on the libcxx-dev mailing list and we got overall
consensus on the direction.

Diff Detail

Event Timeline

ldionne created this revision.Mar 12 2020, 3:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
phosek accepted this revision.Mar 12 2020, 3:41 PM
phosek added a subscriber: phosek.

LGTM

ldionne accepted this revision.Mar 30 2020, 2:57 PM
This revision is now accepted and ready to land.Mar 30 2020, 2:57 PM
This revision was automatically updated to reflect the committed changes.
mgorny added inline comments.Apr 28 2020, 10:57 PM
libcxx/CMakeLists.txt
4

How does this interface with using other C++ ABI libraries?

ldionne marked an inline comment as done.Apr 29 2020, 8:43 AM
ldionne added inline comments.
libcxx/CMakeLists.txt
4

It makes no difference -- the requirement is only that the libcxxabi sources be available. Essentially, we want to start taking advantage of the fact that we have the monorepo to stop duplicating code.