This is an archive of the discontinued LLVM Phabricator instance.

Differential D76027

[libc++abi] NFC: Simplify extern C declaration
ClosedPublic

Authored by ldionne on Mar 11 2020, 2:23 PM.

Details

Reviewers
EricWF
Group Reviewers
Restricted Project
Commits
rGe6eb942ffa4c: [libc++abi] NFC: Simplify extern C declaration
Summary

It seems to me that abort_message.h is always included in a C++ file, so
it's fine to assume that it's C++ code.

Diff Detail

Unit TestsFailed

TimeTest
20 msClang.Format::Unknown Unit Message ("")

Event Timeline

ldionne created this revision.Mar 11 2020, 2:23 PM
Herald added a reviewer: EricWF. · View Herald TranscriptMar 11 2020, 2:23 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, llvm-commits, dexonsmith, jkorous. · View Herald Transcript
EricWF accepted this revision.Mar 11 2020, 2:30 PM

Why was this file ever getting built as plain C anyway?
All of the libc++abi source files that use it should be C++.

This revision is now accepted and ready to land.Mar 11 2020, 2:30 PM
Harbormaster failed remote builds in B48884: Diff 249758!Mar 11 2020, 3:20 PM
Closed by commit rGe6eb942ffa4c: [libc++abi] NFC: Simplify extern C declaration (authored by ldionne). · Explain WhyMar 11 2020, 3:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxxabi/
src/
11 lines

Diff 249758

libcxxabi/src/abort_message.h

//===-------------------------- abort_message.h-----------------------------===// //===-------------------------- abort_message.h-----------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef __ABORT_MESSAGE_H_ #ifndef __ABORT_MESSAGE_H_
#define __ABORT_MESSAGE_H_ #define __ABORT_MESSAGE_H_
#include "cxxabi.h" #include "cxxabi.h"
#ifdef __cplusplus extern "C" _LIBCXXABI_HIDDEN _LIBCXXABI_NORETURN void
extern "C" {
#endif
_LIBCXXABI_HIDDEN _LIBCXXABI_NORETURN void
abort_message(const char *format, ...) __attribute__((format(printf, 1, 2))); abort_message(const char *format, ...) __attribute__((format(printf, 1, 2)));
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-abort_message(const char *format, ...) __attribute__((format(printf, 1, 2)));
+abort_message(const char* format, ...) __attribute__((format(printf, 1, 2)));
Lint: Pre-merge checks: clang-format: please reformat the code ``` -abort_message(const char *format, ...)…
#ifdef __cplusplus
}
#endif #endif
#endif