This is an archive of the discontinued LLVM Phabricator instance.

Differential D76022

[libc++] Add SHA for C++20 Synchronization Library in ABI changelog
ClosedPublic

Authored by ldionne on Mar 11 2020, 1:02 PM.

Details

Reviewers
EricWF
mclow.lists
Group Reviewers
Restricted Project
Commits
rGd34241a89d11: [libc++] Add SHA for C++20 Synchronization Library in ABI changelog
Summary

This is mostly a means to test a new Herald rule for libc++ reviews.

Diff Detail

Unit TestsFailed

TimeTest
20 msClang.Format::Unknown Unit Message ("")

Event Timeline

ldionne created this revision.Mar 11 2020, 1:02 PM
Herald added a reviewer: EricWF. · View Herald TranscriptMar 11 2020, 1:02 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, dexonsmith, jkorous. · View Herald Transcript
EricWF accepted this revision.Mar 11 2020, 1:12 PM
This revision is now accepted and ready to land.Mar 11 2020, 1:12 PM
Herald added a reviewer: mclow.lists. · View Herald TranscriptMar 11 2020, 1:12 PM
Harbormaster failed remote builds in B48870: Diff 249730!Mar 11 2020, 1:35 PM
Closed by commit rGd34241a89d11: [libc++] Add SHA for C++20 Synchronization Library in ABI changelog (authored by ldionne). · Explain WhyMar 11 2020, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
lib/
abi/
2 lines

Diff 249730

libcxx/lib/abi/CHANGELOG.TXT

Show All 10 Lines
Afterwards the ABI list should be updated to include the new changes. Afterwards the ABI list should be updated to include the new changes.
New entries should be added directly below the "Version" header. New entries should be added directly below the "Version" header.
------------ ------------
Version 10.0 Version 10.0
------------ ------------
* TODO - [libc++] Implementation of C++20's P1135R6 for libcxx * 54fa9ecd3088 - [libc++] Implementation of C++20's P1135R6 for libcxx
libc++ now implements P1135R6 (The C++20 Synchronization Library), which libc++ now implements P1135R6 (The C++20 Synchronization Library), which
adds a few symbols to the dylib. This is backwards-compatible since we're adds a few symbols to the dylib. This is backwards-compatible since we're
just adding new symbols. just adding new symbols.
x86_64-unknown-linux-gnu x86_64-unknown-linux-gnu
------------------------ ------------------------
TODO TODO
▲ Show 20 Lines • Show All 605 Lines • Show Last 20 Lines