This is an archive of the discontinued LLVM Phabricator instance.

Differential D76015

[clang-tidy] Mock system headers for portability-restrict-system-includes tests.
ClosedPublic

Authored by PaulkaToast on Mar 11 2020, 11:16 AM.

Details

Reviewers
RKSimon
aaron.ballman
Commits
rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.
Summary

Didn't realize that headers such as stddef.h may not exist on all systems. This patch mocks the headers so that the check's tests work on all systems. (:

Diff Detail

Event Timeline

PaulkaToast created this revision.Mar 11 2020, 11:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2020, 11:16 AM
Herald added subscribers: cfe-commits, xazax.hun. · View Herald Transcript
aaron.ballman accepted this revision.Mar 11 2020, 11:24 AM

LGTM!

This revision is now accepted and ready to land.Mar 11 2020, 11:24 AM
Harbormaster completed remote builds in B48848: Diff 249691.Mar 11 2020, 11:53 AM
Closed by commit rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests. (authored by PaulkaToast). · Explain WhyMar 11 2020, 12:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
test/
clang-tidy/
checkers/
Inputs/
portability-restrict-system-includes/
system/
stddef.h
cstdarg.h
stdint.h
cstdlib.h
system/
3 lines
3 lines
3 lines

Diff 249691

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/a.h

  • This file was moved to clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/float.h.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/cstdarg.h

  • This file was moved to clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/stddef.h.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/cstdlib.h

  • This file was moved to clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/stdint.h.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/float.h

  • This file was moved from clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/a.h.
The contents of this file were not changed.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/j.h

  • This file was deleted.
The contents of this file were not changed.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/stddef.h

  • This file was moved from clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/cstdarg.h.
The contents of this file were not changed.

clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/stdint.h

  • This file was moved from clang-tools-extra/test/clang-tidy/checkers/Inputs/portability-restrict-system-includes/system/cstdlib.h.
The contents of this file were not changed.

clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp

// RUN: %check_clang_tidy %s portability-restrict-system-includes %t \ // RUN: %check_clang_tidy %s portability-restrict-system-includes %t \
// RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '*,-stddef.h'}]}" // RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '*,-stddef.h'}]}" \
// RUN: -- -isystem %S/Inputs/portability-restrict-system-includes/system
// Test block-list functionality: allow all but stddef.h. // Test block-list functionality: allow all but stddef.h.
#include <stddef.h> #include <stddef.h>
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stddef.h not allowed // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stddef.h not allowed
#include <stdint.h> #include <stdint.h>
#include <float.h> #include <float.h>

clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp

// RUN: %check_clang_tidy %s portability-restrict-system-includes %t \ // RUN: %check_clang_tidy %s portability-restrict-system-includes %t \
// RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,stddef.h'}]}" // RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,stddef.h'}]}" \
// RUN: -- -isystem %S/Inputs/portability-restrict-system-includes/system
// Test allow-list functionality: disallow all but stddef.h. // Test allow-list functionality: disallow all but stddef.h.
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stdint.h not allowed // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stdint.h not allowed
#include <float.h> #include <float.h>
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed

clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp

// RUN: %check_clang_tidy %s portability-restrict-system-includes %t \ // RUN: %check_clang_tidy %s portability-restrict-system-includes %t \
// RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,std*.h'}]}" // RUN: -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,std*.h'}]}" \
// RUN: -- -isystem %S/Inputs/portability-restrict-system-includes/system
// Test glob functionality: disallow all headers except those that match // Test glob functionality: disallow all headers except those that match
// pattern "std*.h". // pattern "std*.h".
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <float.h> #include <float.h>
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed